[PM-11941] Migrate TOTP Generator to use SDK #12987
Open
+348
−445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed strict typescript issues
|
New Issues (13)Checkmarx found the following issues in this Pull Request
Fixed Issues (4)Great job! The following issues were fixed in this Pull Request
|
Hinton
reviewed
Jan 21, 2025
coroiu
reviewed
Jan 27, 2025
coroiu
reviewed
Jan 27, 2025
apps/browser/src/autofill/browser/context-menu-clicked-handler.ts
Outdated
Show resolved
Hide resolved
coroiu
reviewed
Jan 29, 2025
| /** | ||
| * Represents TOTP information including display formatting and timing | ||
| */ | ||
| export type TotpInfo = { |
There was a problem hiding this comment.
question(non-blocking): are we defining the type here but not using it here? It seems the implementation for mapping TotpResponse to TotpInfo is in view.component.ts?
There was a problem hiding this comment.
totp-countdown.component.ts also uses it
jprusik
reviewed
Feb 4, 2025
| await this.totpService.getCode(cipher.login.totp), | ||
| ); | ||
| const totpResponse = await firstValueFrom(this.totpService.getCode$(cipher.login.totp)); | ||
| this.platformUtilsService.copyToClipboard(totpResponse.code); |
There was a problem hiding this comment.
Is totpResponse guaranteed to have a code property in this scenario (and elsewhere)?
There was a problem hiding this comment.
I think this is a similar question to this #12987 (comment), it is not guaranteed. How would you prefer errors in this scenario to be handled in the autofill context?
There was a problem hiding this comment.
Naively, I'd probably do something like
const totpResponse = await firstValueFrom(this.totpService.getCode$(cipher.login.totp));
if (totpResponse?.code) {
this.platformUtilsService.copyToClipboard();
} else {
/*
let the user know the copy didn't happen in whatever way
makes sense for the context (toast, console error, etc)
*/
}
jprusik
reviewed
Feb 4, 2025
Comment on lines
975
to
977
| let totpValue = ( | ||
| await firstValueFrom(this.totpService.getCode$(options.cipher.login.totp)) | ||
| ).code; |
There was a problem hiding this comment.
readability nit:
Suggested change
| let totpValue = ( | |
| await firstValueFrom(this.totpService.getCode$(options.cipher.login.totp)) | |
| ).code; | |
| const totpResponse = await firstValueFrom( | |
| this.totpService.getCode$(options.cipher.login.totp), | |
| ); | |
| let totpValue = totpResponse.code; |
jprusik
previously approved these changes
Feb 4, 2025
jprusik
previously approved these changes
Feb 5, 2025
coroiu
previously approved these changes
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-11941
📔 Objective
Migrate Totp Generation service to use sdk. This PR depends on bitwarden/sdk-internal#126
📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes