Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[deps] Platform: Update electron-builder to v25 #10879

Closed
wants to merge 1 commit into from
Closed

[deps] Platform: Update electron-builder to v25 #10879

wants to merge 1 commit into from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Sep 4, 2024 •
edited
Loading

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
electron-builder (source) 24.13.3 -> 25.1.8 age adoption passing confidence

Release Notes

electron-userland/electron-builder (electron-builder)

v25.1.8

Compare Source

Patch Changes

v25.1.7

Compare Source

Patch Changes

v25.1.6

Compare Source

Patch Changes

v25.1.5

Compare Source

Patch Changes

v25.1.4

Compare Source

Patch Changes

v25.1.3

Compare Source

Patch Changes

v25.1.2

Compare Source

Patch Changes

v25.1.0

Compare Source

Patch Changes

v25.0.6

Compare Source

Patch Changes

v25.0.5

Compare Source

Patch Changes

v25.0.4

Compare Source

Patch Changes

v25.0.3

Compare Source

Patch Changes

v25.0.2

Compare Source

Patch Changes

v25.0.1

Compare Source

Patch Changes

v25.0.0

Compare Source

Minor Changes
Patch Changes

Configuration

📅 Schedule: Branch creation - "every 2nd week starting on the 2 week of the year before 4am on Monday" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate bot requested a review from a team September 4, 2024 10:43
@djsmith85 djsmith85 self-requested a review September 4, 2024 10:45
@codecov Codecov
Copy link

codecov bot commented Sep 4, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 33.48%. Comparing base (85c6fe3) to head (82d3189).
Report is 68 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #10879      +/-   ##
==========================================
- Coverage   33.48%   33.48%   -0.01%     
==========================================
  Files        2877     2877              
  Lines       89902    89902              
  Branches    17109    17109              
==========================================
- Hits        30108    30104       -4     
- Misses      57415    57419       +4     
  Partials     2379     2379

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bitwarden-bot bitwarden-bot changed the title [deps] Tools: Update electron-builder to v25 [PM-11630] [deps] Tools: Update electron-builder to v25 Sep 4, 2024
@bitwarden-bot
Copy link

Internal tracking:

@renovate renovate bot changed the title [PM-11630] [deps] Tools: Update electron-builder to v25 [deps] Tools: Update electron-builder to v25 Sep 4, 2024
@renovate renovate bot force-pushed the renovate/electron-builder-25.x branch from 6b717c5 to 89714b2 Compare September 10, 2024 10:05
@renovate renovate bot force-pushed the renovate/electron-builder-25.x branch from 89714b2 to bc22dc5 Compare September 18, 2024 21:44
@renovate renovate bot force-pushed the renovate/electron-builder-25.x branch 3 times, most recently from bbdbaf5 to d3956c7 Compare October 1, 2024 11:21
@renovate renovate bot force-pushed the renovate/electron-builder-25.x branch 2 times, most recently from 9b1fe6d to c4eeb8a Compare October 8, 2024 18:21
@renovate renovate bot force-pushed the renovate/electron-builder-25.x branch 2 times, most recently from b54850a to 01860c2 Compare October 12, 2024 18:23
@renovate renovate bot force-pushed the renovate/electron-builder-25.x branch from 01860c2 to 4e83484 Compare October 23, 2024 14:11
@renovate renovate bot force-pushed the renovate/electron-builder-25.x branch from 4e83484 to 06a2b49 Compare November 4, 2024 17:10
@djsmith85 djsmith85 requested review from a team and addisonbeck and removed request for a team and djsmith85 November 5, 2024 12:36
@djsmith85 djsmith85 changed the title [deps] Tools: Update electron-builder to v25 [deps] Platform: Update electron-builder to v25 Nov 5, 2024
@renovate renovate bot force-pushed the renovate/electron-builder-25.x branch 4 times, most recently from b37dabf to a86fa18 Compare November 12, 2024 01:18
@renovate renovate bot force-pushed the renovate/electron-builder-25.x branch 3 times, most recently from 466067b to ca496c7 Compare November 19, 2024 13:33
@dani-garcia
Copy link
Member

@addisonbeck I was looking into this a while ago when working on #10073, where I was testing with v25 alpha.

The breaking change is due to a bug in electron builder, which is installing the native dependencies in the build folder using symlinks while at the same time complaining that those files are outside the build folder. Back then v25 was in alpha so I was hoping that it would be fixed by the time the final release was done, but at least it seems to be solved in v26 alpha: electron-userland/electron-builder#8673

From my point of view we can just wait until v26 is released, but if you want this is how I solved it back then:

We need make electron builder use the npm install --install-links argument when installing the native dependencies. This will cause the files to be copied over instead of symlinked. This can be done with the npmArgs option in electron-builder.json:

{
  ...
  "directories": {        ...       },
  "npmArgs": ["--install-links"],                     <!---Adding this here
  "afterSign": "scripts/after-sign.js",

@renovate renovate bot force-pushed the renovate/electron-builder-25.x branch from ca496c7 to 307ccf6 Compare November 26, 2024 20:34
@renovate renovate bot force-pushed the renovate/electron-builder-25.x branch from 307ccf6 to 82d3189 Compare November 26, 2024 21:37
@addisonbeck
Copy link
Contributor

I agree, waiting until v26 seems harmless and this isn't worth adding this argument.

@addisonbeck addisonbeck closed this Dec 6, 2024
@renovate Renovate
Copy link
Contributor Author

renovate bot commented Dec 6, 2024

Renovate Ignore Notification

Because you closed this PR without merging, Renovate will ignore this update. You will not get PRs for any future 25.x releases. But if you manually upgrade to 25.x then Renovate will re-enable minor and patch updates automatically.

If you accidentally closed this PR, or if you changed your mind: rename this PR to get a fresh replacement PR.

@renovate renovate bot deleted the renovate/electron-builder-25.x branch December 6, 2024 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addisonbeck addisonbeck Awaiting requested review from addisonbeck addisonbeck was automatically assigned from bitwarden/team-platform-dev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bitwarden-bot @dani-garcia @addisonbeck