Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display bottom app bar for navigation #24

Merged
merged 5 commits into from
Apr 13, 2024
Merged

Conversation

SaintPatrck
Copy link
Contributor

@SaintPatrck SaintPatrck commented Apr 12, 2024

🎟️ Tracking

N/A

📔 Objective

Display bottom navigation bar with "Verification Codes and Settings options.

📸 Screenshots

Screen Dark Mode Light Mode
Authenticator Nav Bar Screen image image

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link
Contributor

github-actions bot commented Apr 12, 2024

Logo
Checkmarx One – Scan Summary & Details1234ca7f-365d-42ae-8049-3b911df296ac

No New Or Fixed Issues Found

@SaintPatrck SaintPatrck changed the title bottombar-navigation Display bottom app bar for navigation Apr 12, 2024
…r-navigation

# Conflicts:
#	app/src/main/kotlin/com/x8bit/bitwarden/authenticator/ui/authenticator/feature/itemlisting/ItemListingGraphNavigation.kt
#	app/src/main/res/values/strings.xml
@SaintPatrck SaintPatrck marked this pull request as ready for review April 13, 2024 21:59
@SaintPatrck SaintPatrck requested a review from a team as a code owner April 13, 2024 21:59
@SaintPatrck SaintPatrck merged commit ea58313 into main Apr 13, 2024
5 checks passed
@SaintPatrck SaintPatrck deleted the bottombar-navigation branch April 13, 2024 22:06
ahaisting-livefront added a commit that referenced this pull request Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants