Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct renovate ruby manager declaration to use bundler #15

Merged
merged 2 commits into from
Apr 3, 2024

Conversation

SaintPatrck
Copy link
Contributor

🎟️ Tracking

#14

📔 Objective

Fix Renovate config to use bundler for managing ruby gems.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@SaintPatrck SaintPatrck requested a review from a team as a code owner April 3, 2024 13:33
@@ -51,7 +51,7 @@
"patch"
],
"matchManagers": [
"ruby"
"bundler"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⛏️ Line 47 is still "ruby".

Also, the description is usually omitted for these sort of boilerplate groups.

Copy link
Contributor

github-actions bot commented Apr 3, 2024

Logo
Checkmarx One – Scan Summary & Detailsb44331d9-0313-4af5-848e-aeb6ba53799d

No New Or Fixed Issues Found

KatherineInCode
KatherineInCode previously approved these changes Apr 3, 2024
Replace ruby references with bundler and delete redundant description.
@SaintPatrck SaintPatrck merged commit 6a226f2 into main Apr 3, 2024
6 checks passed
@SaintPatrck SaintPatrck deleted the ISSUE-14_fix-renovate-config branch April 3, 2024 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants