Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PM-17769 add thinner version of vault icon for the settings #4704

Merged
merged 1 commit into from
Feb 10, 2025

Conversation

dseverns-livefront
Copy link
Collaborator

@dseverns-livefront dseverns-livefront commented Feb 7, 2025

🎟️ Tracking

PM-17769

📔 Objective

  • Add vault icon that looks correct in smaller frame.

📸 Screenshots

Old New
image image

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link
Contributor

github-actions bot commented Feb 7, 2025

Logo
Checkmarx One – Scan Summary & Details150cd114-9a00-47f2-906f-4a09aa35348b

Great job, no security vulnerabilities found in this Pull Request

Copy link

codecov bot commented Feb 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.46%. Comparing base (7e0fc07) to head (8d328a4).
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4704   +/-   ##
=======================================
  Coverage   89.46%   89.46%           
=======================================
  Files         484      484           
  Lines       40574    40574           
  Branches     5768     5768           
=======================================
  Hits        36300    36300           
  Misses       2273     2273           
  Partials     2001     2001           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dseverns-livefront dseverns-livefront added this pull request to the merge queue Feb 10, 2025
@SaintPatrck SaintPatrck removed this pull request from the merge queue due to a manual request Feb 10, 2025
@dseverns-livefront dseverns-livefront merged commit 30e882d into main Feb 10, 2025
9 checks passed
@dseverns-livefront dseverns-livefront deleted the PM-17769-pt-2-the-revengence branch February 10, 2025 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants