Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEVOPS-1746 - Update iOS distribution certificate and profiles #3018

Merged
merged 17 commits into from
Feb 28, 2024

Conversation

vgrassia
Copy link
Member

@vgrassia vgrassia commented Feb 21, 2024

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

This PR updates the iOS distribution certificate and all of the provisioning profiles. I have also included moving all of the files from .github/secrets to an Azure Storage Account named bitwardenci.

Successful run here.

Code changes

  • .github/workflows/build.yml: Formatting. Changed jks and mobileprovision files to download from Storage Account. Download certificate from Key Vault. Remove extra echo and Write-Output to shorten file. Change any ~ to $HOME for consistency. Move some inline bash variables to env key.
  • .github/workflows/release.yml: Formatting. Download files from Storage Account.

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

@vgrassia vgrassia self-assigned this Feb 21, 2024
@vgrassia vgrassia requested review from a team as code owners February 21, 2024 20:05
@bitwarden-bot
Copy link

bitwarden-bot commented Feb 21, 2024

Logo
Checkmarx One – Scan Summary & Details54fd10e8-3c39-45da-aad0-6d9830476c93

New Issues

Severity Issue Source File / Package Checkmarx Insight
MEDIUM Unpinned Actions Full Length Commit SHA /build.yml: 483 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
MEDIUM Unpinned Actions Full Length Commit SHA /build.yml: 731 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
MEDIUM Unpinned Actions Full Length Commit SHA /build.yml: 791 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...

Fixed Issues

Severity Issue Source File / Package
MEDIUM Unpinned Actions Full Length Commit SHA /build.yml: 769
MEDIUM Unpinned Actions Full Length Commit SHA /build.yml: 493
MEDIUM Unpinned Actions Full Length Commit SHA /build.yml: 829

@vgrassia vgrassia enabled auto-merge (squash) February 21, 2024 20:53
.github/workflows/build.yml Outdated Show resolved Hide resolved
.github/workflows/build.yml Outdated Show resolved Hide resolved
Eeebru
Eeebru previously approved these changes Feb 22, 2024
@vgrassia vgrassia requested a review from Eeebru February 28, 2024 00:41
.github/workflows/build.yml Outdated Show resolved Hide resolved
.github/workflows/build.yml Show resolved Hide resolved
Copy link
Member

@fedemkr fedemkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@vgrassia vgrassia merged commit c9fdfa7 into main Feb 28, 2024
12 checks passed
@vgrassia vgrassia deleted the update-certs branch February 28, 2024 12:48
@vgrassia vgrassia requested a review from fedemkr February 28, 2024 12:48
vgrassia added a commit that referenced this pull request Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants