Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wip] Feature/implement missing operations #305

Open
wants to merge 9 commits into
base: develop
Choose a base branch
from

Conversation

xeroc
Copy link
Member

@xeroc xeroc commented Jan 7, 2022

No description provided.

@xeroc xeroc changed the base branch from master to develop January 7, 2022 11:24
@xeroc
Copy link
Member Author

xeroc commented Jan 7, 2022

The following operations are missing:

  • Operation fill_order missing!
  • Operation account_transfer missing!
  • Operation witness_create missing!
  • Operation proposal_delete missing!
  • Operation withdraw_permission_update missing!
  • Operation withdraw_permission_claim missing!
  • Operation withdraw_permission_delete missing!
  • Operation committee_member_update missing!
  • Operation committee_member_update_global_parameters missing!
  • Operation vesting_balance_create missing!
  • Operation transfer_to_blind missing!
  • Operation blind_transfer missing!
  • Operation transfer_from_blind missing!
  • Operation asset_settle_cancel missing!
  • Operation fba_distribute missing!
  • Operation execute_bid missing!
  • Operation htlc_redeemed missing!
  • Operation htlc_refund missing!
  • Operation custom_authority_create_operation missing!
  • Operation custom_authority_update_operation missing!
  • Operation custom_authority_delete_operation missing!

A few of which are quite tough to implement:

  • committee_member_update_global_parameters
  • transfer_to_blind
  • transfer_from_blind
  • blind_transfer

Others seem to be virtual operations (correct me if I am wrong @abitmore):

  • fill_order
  • asset_settle_cancel
  • fba_distribute
  • htlc_redeemed
  • htlc_refund

@xeroc
Copy link
Member Author

xeroc commented Jan 7, 2022

Except for the confidential transactions, the operations themselves are now implemented.

I still need to implemented

  • ChainParameters
  • CestingPolicy
  • Custom Authority: Restrictions

in objects.py

@xeroc
Copy link
Member Author

xeroc commented Jan 7, 2022

I got most operations and types implemented (unittests missing still).

However, I ran into the uglyness of custom_authority restrictions and how it uses arguments. Its doable in python but will produce alot of boiler plate code due to the way how types are used/defined in python.

This will take me more time than anticipated.

@xeroc
Copy link
Member Author

xeroc commented Feb 4, 2022

I decided to make the custom authority operation a separate issue so this doesn't turn into a super-epic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant