TR-106: Get the paneling layout working right #271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
binaryberserker
commented
Jan 6, 2025
| document.body.append(report); | ||
| report.className = "flex" | ||
| report.style = "height: calc(100svh - 5rem);" | ||
| mainContent.append(report); |
There was a problem hiding this comment.
this combined with some of the layout cleanup fixed the scrolling issues
bmomberger-bitovi
approved these changes
Jan 8, 2025
|
@binaryberserker , the E2E tests are failing. Can you check out why? |
pages/index.html.js
Outdated
| <script src="https://connect-cdn.atl-paas.net/all${ | ||
| env.NODE_ENV === "development" ? "-debug" : "" | ||
| }.js"></script> | ||
| <script src="https://connect-cdn.atl-paas.net/all${env.NODE_ENV === "development" ? "-debug" : "" |
There was a problem hiding this comment.
We should not generally be checking "environments" for feature flags. This isn't 12factor. What is this for?
There was a problem hiding this comment.
i didn't add it, the formatter got ahold of this, undo it
binaryberserker
force-pushed
the
dbrandon/TR-106
branch
from
810244f to
18668bd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.