feat: Add reporting rendered framerate #77
Conversation
realeyes-craig
requested review from
dweinber,
stonko1994 and
luckygoyal-bitmovin
|
Just to be clear on |
| @@ -5,6 +5,8 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/) | |||
| and this project adheres to [Semantic Versioning](http://semver.org/). | |||
|
|
|||
| ## [Unreleased] | |||
| ### Added | |||
| - Tracking the current framerate | |||
There was a problem hiding this comment.
| - Tracking the current framerate | |
| - Tracking the framerate for the currently played video quality based on the framerate specified in the manifest file |
| @@ -241,7 +241,7 @@ interface EventEmitter { | |||
|
|
|||
| fireAdErrorEvent(): void; | |||
|
|
|||
| fireVideoPlaybackQualityChangedEvent(bitrate: number): void; | |||
| fireVideoPlaybackQualityChangedEvent(bitrate: number, frameRate: number): void; | |||
There was a problem hiding this comment.
Please make frameRate optional, so we can test events with and without frameRate being available.
| @@ -422,7 +422,7 @@ class PlayerEventHelper implements EventEmitter { | |||
| }); | |||
| } | |||
|
|
|||
| fireVideoPlaybackQualityChangedEvent(bitrate: number): void { | |||
| fireVideoPlaybackQualityChangedEvent(bitrate: number, frameRate: number): void { | |||
There was a problem hiding this comment.
Please make frameRate optional, so we can test events with and without frameRate being available.
| @@ -437,6 +437,7 @@ class PlayerEventHelper implements EventEmitter { | |||
| bitrate: bitrate, | |||
| width: null, | |||
| height: null, | |||
| frameRate: frameRate, | |||
There was a problem hiding this comment.
Please only expose frameRate if it's passed in the signature
| it('report bitrate on event', () => { | ||
| playerMock.eventEmitter.firePlayEvent(); | ||
| playerMock.eventEmitter.firePlayingEvent(); | ||
| playerMock.eventEmitter.fireVideoPlaybackQualityChangedEvent(2_400_000); | ||
| playerMock.eventEmitter.fireVideoPlaybackQualityChangedEvent(2_400_000, 30); |
There was a problem hiding this comment.
Please add a test case where we don't pass a frame rate and explicitly check that we don't set it (so we don't accidentally break it in the future)
|
|
Added:
targetQuality