Use error codes in error reporting #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zigavehovec
approved these changes
Jan 24, 2025
| @@ -600,15 +600,15 @@ private synchronized void transitionState(ConvivaSdkConstants.PlayerState state) | |||
| }; | |||
|
|
|||
| private final EventListener<PlayerEvent.Error> onPlayerErrorListener = event -> { | |||
| Log.d(TAG, "[Player Event] Error"); | |||
| Log.d(TAG, "[Player Event] Error - " + event.getCode().getValue()); | |||
There was a problem hiding this comment.
Mini nit: extract the code into a variable.
zigavehovec
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When reporting playback errors, we build an error message based on the error code + its message. However, since the switch to Kotlin was made for the
ErrorCode, it no longer reports the numeric value but instead reports the error name. This was unintentional, and this PR reverts to the error code.Changes
Using the errorCode numeric value when building the error message which is reported to conviva.