Do not reset ad break state on ad skip as there might be more ads

bitmovin · Jul 2, 2024 · 3af6cf2 · 3af6cf2
1 parent 7667a01
commit 3af6cf2
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/conviva/src/main/java/com/bitmovin/analytics/conviva/ssai/DefaultSsaiApi.java b/conviva/src/main/java/com/bitmovin/analytics/conviva/ssai/DefaultSsaiApi.java
@@ -89,7 +89,6 @@ public void reportAdSkipped() {
             Log.d(TAG, "No ad break active");
             return;
         }
-        isAdBreakActive = false;
         Log.d(TAG, "Server side ad skipped");
         convivaAdAnalytics.reportAdSkipped();
     }

diff --git a/conviva/src/test/kotlin/com/bitmovin/analytics/conviva/ssai/DefaultSsaiApiTest.kt b/conviva/src/test/kotlin/com/bitmovin/analytics/conviva/ssai/DefaultSsaiApiTest.kt
@@ -11,8 +11,10 @@ import io.mockk.mockk
 import io.mockk.mockkStatic
 import io.mockk.runs
 import io.mockk.slot
+import io.mockk.unmockkStatic
 import io.mockk.verify
 import org.junit.After
+import org.junit.AfterClass
 import org.junit.Before
 import org.junit.BeforeClass
 import org.junit.Test
@@ -189,7 +191,7 @@ class DefaultSsaiApiTest {
         ssaiApi.reportAdSkipped()
 
         verify { adAnalytics.reportAdSkipped() }
-        expectThat(ssaiApi.isAdBreakActive).isFalse()
+        expectThat(ssaiApi.isAdBreakActive).isTrue()
     }
 
     @Test
@@ -245,5 +247,11 @@ class DefaultSsaiApiTest {
             every { Log.i(any(), any()) } returns 0
             every { Log.e(any(), any()) } returns 0
         }
+
+        @JvmStatic
+        @AfterClass
+        fun afterClass() {
+            unmockkStatic(Log::class)
+        }
     }
 }