feat: Implement fillImage retries for elgato-mini and elgator-xl #1613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Julusian
reviewed
May 29, 2021
There was a problem hiding this comment.
It would be better to do the retry from the point where we have newbuffer.
This change isnt guarding against sharp throwing an error, which I think is correct, but each time we retry it is sending the buffer back through sharp to do the same scaling.
Have you used async/await in js before? This function could really do with being rewritten to use that syntax and doing so would make the function possible to do as a while loop instead of chaining function calls
|
Good suggestion on the aysnc/await. I was trying to keep the change minimal, but I agree the async/await is more maintainable than chaining function calls. |
Julusian
reviewed
Jun 7, 2021
Julusian
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The standard lib/usb/elgato.js has a mechanism for retrying the
fillImagecall a couple of times before giving up on the USB device. This Pull Request applies that retry to the elgato-mini and elgato-xl.The original retry logic was added as a result of a discussion on Issue #313 (comment)
In our use case, we had our Mini disconnect from its RPi4 when several image updates were made in quick succession. After running for a month now, we've seen debug logs where it would have disconnected before, but with the patched code it continues working just fine.
Note: I've tested with a Mini but not the XL since I don't have an XL but the code is otherwise identical.