Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add webpush headers, fake encryption for now #35

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ Watch the video (YouTube):
It is the server part of our efforts to draft a WebDAV-Push standard and provide a working implementation (server + client) in order to demonstrate it.

> [!WARNING]
> This extension is in an early stage of development. It is for demonstration and testing purposes only. Don't use it on production systems!
> This extension is in an early stage of development. It is for demonstration and testing purposes only. It also marks unencrypted data as encrypted. Don't use it on production systems!

For instance, push subscriptions currently don't expire and won't be removed when they have become invalid. So the table will grow bigger and bigger and everything will become slow over time. You can however install/enable the extension to test it and disable or remove it again at any time. When the extension is disabled, it doesn't influence your system.

Expand Down
4 changes: 4 additions & 0 deletions lib/PushTransports/WebPushTransport.php
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,10 @@ public function notify(string $userId, string $collectionName, int $subscription
'http' => [
'method' => 'POST',
'content' => $content,
'header' => [
'TTL: 86400',
'Content-Encoding: aes128gcm',
],
],
];

Expand Down
Loading