Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignored warnings for unused classes #383

Merged
merged 1 commit into from
Aug 9, 2024

Conversation

ArnyminerZ
Copy link
Member

Purpose

Fixed proguard warnings

Short description

  • Disabled warnings for com.github.erosb.jsonsKema.*, not used by anything, it looks that it's incorrectly being detected.
  • Disabled warnings for org.jparsec.** and javax.cache.**. Optional features not used by ICSx⁵.

Maybe we should report the issue with com.github.erosb.jsonsKema in ical4j, even though since it has to do with proguard, maybe Ben doesn't want to do a release. What do you think @rfc2822

Checklist

  • The PR has a proper title, description and label.
  • I have self-reviewed the PR.
  • I have added documentation to complex functions and functions that can be used by other modules.
  • I have added reasonable tests or consciously decided to not add tests.

@ArnyminerZ ArnyminerZ self-assigned this Aug 7, 2024
@ArnyminerZ ArnyminerZ linked an issue Aug 7, 2024 that may be closed by this pull request
@rfc2822
Copy link
Member

rfc2822 commented Aug 8, 2024

Maybe we should report the issue with com.github.erosb.jsonsKema in ical4j, even though since it has to do with proguard, maybe Ben doesn't want to do a release. What do you think @rfc2822

Yes, or even submit a PR that deletes these comment lines

@sunkup
Copy link
Member

sunkup commented Aug 9, 2024

Will merge this for now and try to make a release. We can remove it again after the release when the changes in ical4j have been made. See #384 for tracking these changes.

@sunkup sunkup merged commit c68aef7 into dev Aug 9, 2024
7 checks passed
@sunkup sunkup deleted the 376-release-build-fails-due-to-missing-classes branch August 9, 2024 09:59
@sunkup sunkup mentioned this pull request Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Release build fails due to missing classes
3 participants