-
-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use ID to match DB collections with content provider collections #1274
Use ID to match DB collections with content provider collections #1274
Conversation
3b5f685
to
552d1a2
Compare
app/src/main/kotlin/at/bitfire/davdroid/resource/LocalAddressBook.kt
Outdated
Show resolved
Hide resolved
app/src/main/kotlin/at/bitfire/davdroid/settings/migration/AccountSettingsMigration17.kt
Outdated
Show resolved
Hide resolved
Hm the error message looks different at least
|
Yes, and it happened after I removed the exception throw. |
Guess it's then more related to that. Maybe the migration test has to be adapted |
Yes, most likely. After reverting the commit the tests succeed again. This is weird though. It should not have any effect on the test 🤔 |
479991a
to
bb06506
Compare
Now it succeeded. No changes whatsoever 👍 |
- remove unused param - make companion methods internal
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good :)
Purpose
We are currently still using the URL which is error prone. It might change and break the link.
Short description
See also https://github.com/bitfireAT/davx5/issues/603#issuecomment-2314844880
Checklist