Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change warning when Internet is not available #1255

Merged

Conversation

sunkup
Copy link
Member

@sunkup sunkup commented Jan 21, 2025

Please delete this paragraph and other repeating text (like the examples) after reading and before submitting the PR.

Purpose

Currently the warning says "No validated Internet connectivity. Synchronization may not run.", however it's not "maybe", but it will certainly not work. So we should use a better warning text.

Short description

Add new warning text in english and german

  • Automatic synchronization not active (no verified Internet connection)
  • Automatische Synchronisierung nicht aktiv (keine überprüfte Internetverbindung)

Checklist

  • The PR has a proper title, description and label.
  • I have self-reviewed the PR.
  • I have added documentation to complex functions and functions that can be used by other modules.
  • I have added reasonable tests or consciously decided to not add tests.

@sunkup sunkup added the enhancement New feature or request label Jan 21, 2025
@sunkup sunkup requested a review from rfc2822 January 21, 2025 10:20
@sunkup sunkup self-assigned this Jan 21, 2025
@sunkup sunkup linked an issue Jan 21, 2025 that may be closed by this pull request
Copy link
Member

@rfc2822 rfc2822 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The German translation won't be used. We have to commit the English strings.xml first, and then Transifex will either

  • fetch it automatically within one day,
  • or we can upload it with tx push -s.

As soon as the English string is on Transifex, we can translate it on Transifex and it will be taken over when we download them the next time (usually before a release).

@rfc2822 rfc2822 merged commit ca2d57c into main-ose Jan 22, 2025
8 checks passed
@rfc2822 rfc2822 deleted the 1229-change-warning-when-internet-is-not-available branch January 22, 2025 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change warning when Internet is not available
2 participants