Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't remove port from URI of nextcloud login intent #1242

Merged
merged 7 commits into from
Jan 16, 2025
Merged

Don't remove port from URI of nextcloud login intent #1242

merged 7 commits into from
Jan 16, 2025

Conversation

sunkup
Copy link
Member

@sunkup sunkup commented Jan 15, 2025

Purpose

We should not remove the port from the URI passed through nextcloud login intent.

Short description

  • create a test for loginInfoFromIntent
  • fix the URI creation

Checklist

  • The PR has a proper title, description and label.
  • I have self-reviewed the PR.
  • I have added documentation to complex functions and functions that can be used by other modules.
  • I have added reasonable tests or consciously decided to not add tests.

@sunkup sunkup added the bug Something isn't working label Jan 15, 2025
@sunkup sunkup self-assigned this Jan 15, 2025
@sunkup sunkup linked an issue Jan 15, 2025 that may be closed by this pull request
Login from Nextcloud app doesn't hand over port number #1226
Closed
@sunkup sunkup requested a review from ArnyminerZ January 15, 2025 11:56
@sunkup sunkup force-pushed the 1226-login-from-nextcloud-app-doesnt-hand-over-port-number branch from bac11c4 to 2766bb3 Compare January 15, 2025 13:10
rfc2822
rfc2822 approved these changes Jan 16, 2025
View reviewed changes
Copy link
Member

@rfc2822 rfc2822 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done, special ports now work

@rfc2822 rfc2822 merged commit 226583f into main-ose Jan 16, 2025
8 checks passed
@rfc2822 rfc2822 deleted the 1226-login-from-nextcloud-app-doesnt-hand-over-port-number branch January 16, 2025 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rfc2822 rfc2822 rfc2822 approved these changes

@ArnyminerZ ArnyminerZ Awaiting requested review from ArnyminerZ

Assignees

@sunkup sunkup

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Login from Nextcloud app doesn't hand over port number
2 participants
@sunkup @rfc2822