Start migration to Compose Navigation

[ArnyminerZ]

Purpose

As the first step of #1172, started by renaming AccountsActivity to MainActivity, and start adding navigation functionality.

Short description

• Renamed AccountsActivity and its usages to MainActivity.
• Added the compose navigation dependency.
• Added the first route to the nav graph: accounts list.
• Added a method for initializing AccountsRoute from the intent data of MainActivity.
• Added LocalNavController which holds a reference to the currently being used nav controller.
• Moved injection of AccountsDrawerHandler from activity to model to decouple it completely from activities.

Checklist

• The PR has a proper title, description and label.
• I have self-reviewed the PR.
• I have added documentation to complex functions and functions that can be used by other modules.
• I have added reasonable tests or consciously decided to not add tests.

[ArnyminerZ]

I think this can be a good first PR on the topic.

[ArnyminerZ]

LocalNavController is used in order to access the nav controller from outside MainActivity. For example, from a composable:

@Composable
fun Example() {
  val navController = LocalNavController.current

  navController.navigate(ExampleRoute)

[rfc2822]

Can we move the NavController to the navigation package? Just so that there are no packages that only contain one class.

But didn't have an in-depth look yet. Please @sunkup also have a look first (we can talk tomorrow about it).

[sunkup]

Can we move the NavController to the navigation package? Just so that there are no packages that only contain one class.

But didn't have an in-depth look yet. Please @sunkup also have a look first (we can talk tomorrow about it).

@ArnyminerZ maybe you can make the suggested change and request a new review from me? I will use the opportunity to get to know compose navigation.

[ArnyminerZ]

maybe you can make the suggested change and request a new review from me?

Done

[sunkup]

Looks really good!

For some reason I am sceptical about moving the AccountsDrawerHandler injection to the model. I feel like it does not really belong there, but in favor of the new navigation paradigm I can't give a good reason not to do it ...

See the comment about broken reference, but yeah, otherwise it's really nice.

[sunkup]

Deleting the AccountsActivity breaks a reference from jtxBoard: "Drawermenu > Synchronization > Go to collections".

For now, since we don't want to break external references we would need to keep an AccountsActivity and have it redirect to the new MainActivity. See #1172 (comment)

[rfc2822]

Also I think we could inject the AccountsDrawerHandler directly in MainActivity, rather than in a model. Because it's not really a state, and models are basically state holders (+ maybe a little logic).

Also, the idea is that the intro check occurs / the intro is potentially shown when the app UI starts. In the past we could only put it into the launcher activity (AccountsActivity) and hope that this is the first activity started.

In the future we could put it into the MainActivity.onCreate, and later maybe even in the MainActivity's composition.