Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to SecureTextField #1191

Open
wants to merge 2 commits into
base: main-ose
Choose a base branch
from
Open

Migrate to SecureTextField #1191

wants to merge 2 commits into from

Conversation

ArnyminerZ
Copy link
Member

Purpose

Use SecureTextField for PasswordTextField

Short description

  • Upgraded Material 3 to 1.4.0-alpha05 (We should wait merging this until 1.4.0 stable is released).
  • Using OutlinedSecureTextField in PasswordTextField.
  • Migrated all usages of String password into TextFieldState. Followed the example here for the viewmodel implementation.

Checklist

  • The PR has a proper title, description and label.
  • I have self-reviewed the PR.
  • I have added documentation to complex functions and functions that can be used by other modules.
  • I have added reasonable tests or consciously decided to not add tests.

@ArnyminerZ
Using SecureTextField
0696576 
Signed-off-by: Arnau Mora Gras <[email protected]>
@ArnyminerZ ArnyminerZ added the refactoring Internal improvement of existing functions label Dec 23, 2024
@ArnyminerZ ArnyminerZ linked an issue Dec 23, 2024 that may be closed by this pull request
Replace PasswordTextField.kt by SecureTextField #1190
Open
@ArnyminerZ ArnyminerZ marked this pull request as ready for review December 23, 2024 07:15
@ArnyminerZ ArnyminerZ self-assigned this Dec 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ArnyminerZ ArnyminerZ

Labels
refactoring Internal improvement of existing functions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace PasswordTextField.kt by SecureTextField
1 participant
@ArnyminerZ