Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Login over Intent doesn't directly go to correct login page #1244

Open
2 tasks done
rfc2822 opened this issue Jan 16, 2025 · 0 comments
Open
2 tasks done

Login over Intent doesn't directly go to correct login page #1244

rfc2822 opened this issue Jan 16, 2025 · 0 comments
Labels
bug Something isn't working

Comments

@rfc2822
Copy link
Member

rfc2822 commented Jan 16, 2025

Problem scope

  • I'm sure that this is a DAVx⁵ problem.

App version

  • I'm using the latest available DAVx⁵ version.

Android version and device/firmware type

No response

Steps to reproduce

  1. Login with an Intent like this: adb shell am start -d caldavs://user:[email protected]:444/path at.bitfire.davdroid/.ui.setup.LoginActivity
  2. The LoginActivity will appear and Login with URL and password is selected.
  3. Click Continue and then you will see the login data.

Actual result

The Login type page is not skipped, a user has to select Login with URL and password before the intent data appear.

Expected result

The login type selection could be skipped when the login intent data contains

  • a valid URL → directly go to Login with URL and user name
  • a mailto URI → directly go to Login with email address

Further info

When the loginFlow extra is set, we already skip the initial login page as expected.
See https://manual.davx5.com/integration.html#launching-the-davx5-login-screen

I think we have to adapt the [Standard]LoginTypesProvider.intentToInitialLoginType to check whether there's a URL / email address.

At that point we can also better document what it returns in LoginTypesProvider KDoc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Todo
Development

No branches or pull requests

1 participant