Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Posts: check YAML formatting #1629

Merged

Conversation

harding
Copy link
Collaborator

@harding harding commented Apr 25, 2024

Part of #1551

Some of our posts contain an extra space in the YAML header between a key and value, e.g.:

title : 'Bulletin Hebdomadaire Bitcoin Optech #290'

Jekyll strips the extra space, so the key becomes title. Hugo preserves the extra space, so the field doesn't work as expected.

This PR eliminates the extra space in the source file and adds a test to help avoid future extra spaces.

@bitschmidty bitschmidty force-pushed the 2024-04-prehugo-yaml-formatting branch from b8306de to 464197f Compare April 27, 2024 09:40
Copy link
Contributor

@bitschmidty bitschmidty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pushed a small comment wording change.

  • Pulled locally and built
  • Rebased on master which included a new fr translation that violated the check
  • Confirmed that the violation was caught by the new check
  • Fixed the new fr translation format to be compliant

@Copinmalin be aware that this PR makes the yaml formatting (title/permalink/name fields) more strict

@bitschmidty bitschmidty merged commit 935b41a into bitcoinops:master Apr 27, 2024
2 checks passed
@murchandamus
Copy link
Collaborator

Post merge ACK

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants