Rename secp256k1 to secp for modules, packages, directories #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msgilligan
force-pushed
the
msgilligan/secp256k1-to-secp-modules-and-packabges
branch
from
338be72 to
fc699bd
Compare
And related places in the build files and documentation This eliminates warnings from the compiler about module names ending in a digit and reduces general verbosity. The current intention is to leave full Secp256K1 prefix on the types (classes) because they do refer to that specific ECC curve.
msgilligan
force-pushed
the
msgilligan/secp256k1-to-secp-modules-and-packabges
branch
from
fc699bd to
2fbac3c
Compare
|
There are some individual classes that should probably be renamed, but we'll do that in a follow-on PR. |
schildbach
approved these changes
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And related places in the build files and documentation
This eliminates warnings from the compiler about module names ending in a digit and reduces general verbosity.
The current intention is to leave full Secp256K1 prefix on the types (classes) because they do refer to that specific ECC curve.