Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(SPV-1475): register v2 swagger #898

Merged
merged 7 commits into from
Feb 10, 2025

Conversation

pawellewandowski98
Copy link
Contributor

Description

  • Generate one more file which is saved in docs directory
  • Host new file as v2 swagger documentation

Pull Request Checklist

  • 📖 I created my PR using provided : CODE_STANDARDS
  • 📖 I have read the short Code of Conduct: CODE_OF_CONDUCT
  • 🏠 I tested my changes locally.
  • ✅ I have provided tests for my changes.
  • 📝 I have used conventional commits.
  • 📗 I have updated any related documentation.
  • 💾 PR was issued based on the Github or Jira issue.

@pawellewandowski98 pawellewandowski98 self-assigned this Feb 8, 2025
@pawellewandowski98 pawellewandowski98 requested a review from a team as a code owner February 8, 2025 10:34
Copy link

github-actions bot commented Feb 8, 2025

Manual Tests

💚 Manual testing by @dorzepowski resulted in success.

@codecov-commenter
Copy link

codecov-commenter commented Feb 8, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 70.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 52.68%. Comparing base (5dac1a5) to head (86b1c22).

Files with missing lines Patch % Lines
actions/v2/base/routes.go 62.50% 2 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #898      +/-   ##
==========================================
- Coverage   52.79%   52.68%   -0.11%     
==========================================
  Files         402      403       +1     
  Lines       17956    17966      +10     
==========================================
- Hits         9479     9466      -13     
- Misses       7727     7749      +22     
- Partials      750      751       +1     
Flag Coverage Δ
unittests 52.68% <70.00%> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
actions/v2/register.go 100.00% <100.00%> (ø)
actions/v2/base/routes.go 62.50% <62.50%> (ø)

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5dac1a5...86b1c22. Read the comment docs.

@dorzepowski dorzepowski added the tested PR was tested by a team member label Feb 10, 2025
@pawellewandowski98 pawellewandowski98 merged commit 23c44fa into main Feb 10, 2025
13 checks passed
@pawellewandowski98 pawellewandowski98 deleted the feat/SPV-1475-host-swagger-for-v2-endpoints branch February 10, 2025 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tested PR was tested by a team member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants