Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(BUX-411): adjustments to bux taskmanager #379

Merged
merged 3 commits into from
Dec 20, 2023

Conversation

chris-4chain
Copy link
Contributor

@chris-4chain chris-4chain commented Dec 19, 2023

Pull Request Checklist

  • πŸ“– I created my PR using provided : CODE_STANDARDS
  • πŸ“– I have read the short Code of Conduct: CODE_OF_CONDUCT
  • 🏠 I tested my changes locally.
  • βœ… I have provided tests for my changes.
  • πŸ“ I have used conventional commits.
  • πŸ“— I have updated any related documentation.
  • πŸ’Ύ PR was issued based on the Github or Jira issue.

According to this PR: BuxOrg/bux#510

I adjusted taskmanager-related configuration to make it work. I assumed, that the new bux release with my changes from that PR will be in v0.9.0 version.

@chris-4chain chris-4chain requested a review from a team as a code owner December 19, 2023 11:42
Copy link
Contributor

mergify bot commented Dec 19, 2023

Welcome to our open-source project @chris-4chain! πŸ’˜

Copy link

codecov bot commented Dec 20, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (0b2c90f) 39.13% compared to head (bd09394) 39.23%.
Report is 2 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #379      +/-   ##
==========================================
+ Coverage   39.13%   39.23%   +0.09%     
==========================================
  Files          44       44              
  Lines        1620     1611       -9     
==========================================
- Hits          634      632       -2     
+ Misses        950      944       -6     
+ Partials       36       35       -1     
Flag Coverage Ξ”
unittests 39.23% <66.66%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Ξ”
config/services.go 42.46% <66.66%> (+0.54%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data
Powered by Codecov. Last update 0b2c90f...bd09394. Read the comment docs.

@mergify mergify bot merged commit 13dfd31 into master Dec 20, 2023
10 checks passed
@mergify mergify bot deleted the refactor-411-taskmanager-simplification branch December 20, 2023 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants