-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ingress #607
Add ingress #607
Conversation
56a5e87
to
22f9a42
Compare
on digital ocean:
ingress is running in the cluster:
|
And the ingress is there, and works!
|
Ok so this works! yay. just had to wait a minute |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 🚀
|
||
|
||
INGRESS_HELM_COMMANDS = [ | ||
"helm repo add ingress-nginx https://kubernetes.github.io/ingress-nginx", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
its ingress-nginx
even for caddy?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes it is because the ingress controller is provided by nginx and caddy is the reverse proxy. I know I know, layers upon layers but that's how it is!
@pinheadmz I'll add another line in the |
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
To test:
Tested on Minikube, Docker Desktop and Google so especially looking for Digital Ocean users.