fix: vertical alignment in cards #95

TopETH · 2024-04-16T04:11:51Z

Summary by CodeRabbit

Style
- Updated styling on the AuctionCard component to enhance layout and responsiveness.
Refactor
- Added an export statement for a new module in the smartsale-db package.

coderabbitai · 2024-04-16T04:11:57Z

Walkthrough

The changes involve a styling update in the AuctionCard component of the web application. The modification enhances the layout by adjusting the className property in the Link component, transitioning from a fixed maximum width setting to a flexible column display.

Changes

File Path	Change Summary
`.../home/auction-card.tsx`	Updated `className` in `Link` to `'mx-auto size-full flex flex-col'` from `'mx-auto size-full max-w-[450px]'`
`packages/smartsale-db/src/index.ts`	Added export statement for new module `../prisma/client` in addition to existing export for `./client`

Poem

🐰✨
In the realm of code, where the rabbits play,
A small tweak was made on a sunny day.
From fixed width to columns so neat,
Now the auction cards look quite elite!
Hop, hop, hooray, let's celebrate the feat! 🎉
🐰✨

Recent Review Details

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between c13dfe6 and b0fddf1.

Files selected for processing (1)

packages/smartsale-db/src/index.ts (1 hunks)

Files skipped from review due to trivial changes (1)

packages/smartsale-db/src/index.ts

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

vercel · 2024-04-16T04:11:58Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
bitcash-faucet	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Apr 16, 2024 1:34pm
bitlauncher	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Apr 16, 2024 1:34pm

github-actions · 2024-04-16T04:15:23Z

⚡️ Lighthouse report

Page: https://bitlauncher-cg9iftcbm-bitcash.vercel.app/
Report https://storage.googleapis.com/lighthouse-infrastructure.appspot.com/reports/1713274476174-57485.report.html

Category	Score
🟠 Performance	74
🟢 Accessibility	93
🟢 Best practices	100
🟠 SEO	67
🔴 PWA	38

Page: https://bitlauncher-cg9iftcbm-bitcash.vercel.app/about
Report https://storage.googleapis.com/lighthouse-infrastructure.appspot.com/reports/1713274476714-41340.report.html

Category	Score
🔴 Performance	32
🟠 Accessibility	86
🟠 Best practices	74
🟠 SEO	86
🔴 PWA	38

Page: https://bitlauncher-cg9iftcbm-bitcash.vercel.app/security
Report https://storage.googleapis.com/lighthouse-infrastructure.appspot.com/reports/1713274477142-21036.report.html

Category	Score
🔴 Performance	41
🟠 Accessibility	83
🟠 Best practices	74
🟠 SEO	85
🔴 PWA	38

Page: https://bitlauncher-cg9iftcbm-bitcash.vercel.app/bitcash-bitlauncher
Report https://storage.googleapis.com/lighthouse-infrastructure.appspot.com/reports/1713274477525-95975.report.html

Category	Score
🔴 Performance	42
🟠 Accessibility	89
🟠 Best practices	74
🟠 SEO	86
🔴 PWA	38

AndlerRL

LGTM!

AndlerRL · 2024-04-16T05:22:39Z

apps/webapp/components/routes/home/auction-card.tsx

I recommend to push the action button wrapper to the bottom by giving the mt-auto. On smaller screens we might get the same issue.

Also continue adding a number to this file to make the build happen after merge -> https://github.com/bitcashorg/smartsale/blob/develop/packages/smartsale-db/src/client.ts#L5

I think we already have it there. @AndlerRL Could you please check it out again?

* docs: update readme * devops: add github actions (#80) * devops: add github actions * chore: update bunlock * chore: disable eslint action * devops: supabase (#79) * devops: supabase init * feat: initial db schema migration * devops: supabase project * chore: slow transitions, layout, cls, remove motion, supa, auth, ui fixes (#89) * chore: fix jsx structure * chore: fix layout and cls, removed motion * chore: fix layout and cls, removed motion * chore: format code * chore: correct project id on lhci github action * chore: layout, metadata, navigation adjustments * wip: project landing page header updates * wip: project landing page header updates * wip: project landing page header updates * wip: project landing page header updates * wip: mobile nav * fix: padding in project card * feat: initial fade in * fix: adjust padding of project card for mobile * wip: mobile nav * feat: mobile nav * feat: mobile nav * feat: mobile session * fix: hide mobile nav trigger * wip: desktop login and wallet connection flow * wip: desktop login and wallet connection flow * chore: updte bun lock * devops: update lhci, re-enable vconsole on test * fix: build * fix: restore blur bg color in auction card * fix: use same color for title and description * devops: supabase (#79) * devops: supabase init * feat: initial db schema migration * devops: supabase project * fix: dark mode color * fix: build --------- Co-authored-by: Nathanael Liu <[email protected]> * feat: whitepaper * chore: update navlinks * chore: close issues Close #61 Close #54 Close #55 Close #60 Close #62 Close #64 Close #67 Close #69 Close #72 Close #77 Close #78 Close #84 Close #68 Close #63 Close #86 Close #34 Related #89 * chore: udpate whitepaper link * feat: project data card 1 * feat: improve project hero in project landing * fix: vertical alignment in cards (#95) * fix: vertical alignment in cards * chore: add number * impr(webapp): adding appName to signatureRequest * feat(webapp): double table on auciton data card * feat(webapp): double table on auciton data card * feat(webapp): double table on auciton data card --------- Co-authored-by: Gabo Esquivel <[email protected]> Co-authored-by: Nathanael Liu <[email protected]>

AndlerRL · 2024-04-19T23:48:46Z

Development Support, Nathan - April 2024, 1 of 2

fix: vertical alignment in cards

c13dfe6

TopETH requested review from gaboesquivel and AndlerRL April 16, 2024 04:11

TopETH self-assigned this Apr 16, 2024

vercel bot had a problem deploying to Preview – bitlauncher April 16, 2024 04:12 Failure

AndlerRL approved these changes Apr 16, 2024

View reviewed changes

AndlerRL reviewed Apr 16, 2024

View reviewed changes

chore: add number

b0fddf1

vercel bot deployed to Preview – bitlauncher April 16, 2024 13:33 View deployment

vercel bot deployed to Preview – bitcash-faucet April 16, 2024 13:34 View deployment

TopETH requested a review from AndlerRL April 16, 2024 15:16

gaboesquivel approved these changes Apr 16, 2024

View reviewed changes

gaboesquivel merged commit d20107d into develop Apr 16, 2024
4 checks passed

gaboesquivel deleted the topeth/fix-vertical-alignment-in-cards branch April 16, 2024 16:50

AndlerRL mentioned this pull request Apr 16, 2024

chore: april 1st release #98

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: vertical alignment in cards #95

fix: vertical alignment in cards #95

TopETH commented Apr 16, 2024 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Apr 16, 2024 •

edited

Loading

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (`.coderabbit.yaml`)

Documentation and Community

vercel bot commented Apr 16, 2024 •

edited

Loading

github-actions bot commented Apr 16, 2024 •

edited

Loading

AndlerRL left a comment

AndlerRL Apr 16, 2024

TopETH Apr 16, 2024

AndlerRL commented Apr 19, 2024

fix: vertical alignment in cards #95

fix: vertical alignment in cards #95

Conversation

TopETH commented Apr 16, 2024 • edited by coderabbitai bot Loading

Summary by CodeRabbit

coderabbitai bot commented Apr 16, 2024 • edited Loading

Walkthrough

Changes

Poem

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (.coderabbit.yaml)

Documentation and Community

vercel bot commented Apr 16, 2024 • edited Loading

github-actions bot commented Apr 16, 2024 • edited Loading

AndlerRL left a comment

Choose a reason for hiding this comment

AndlerRL Apr 16, 2024

Choose a reason for hiding this comment

TopETH Apr 16, 2024

Choose a reason for hiding this comment

AndlerRL commented Apr 19, 2024

TopETH commented Apr 16, 2024 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Apr 16, 2024 •

edited

Loading

CodeRabbit Configration File (`.coderabbit.yaml`)

vercel bot commented Apr 16, 2024 •

edited

Loading

github-actions bot commented Apr 16, 2024 •

edited

Loading