Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: og image with chatbot avatar #179

Merged
merged 1 commit into from
Apr 14, 2024
Merged

Conversation

gaboesquivel
Copy link
Member

@gaboesquivel gaboesquivel commented Apr 14, 2024

first version of the dynamic og image card, we still need to add dynamic category color. currently fixed to red
image

related #140

Summary by CodeRabbit

  • New Features

    • Enhanced URL generation to improve readability and SEO by using slugs for chatbot names.
    • Updated the display of thread information with improved content structure and styling.
    • Introduced category display in account details for better user information.
  • Refactor

    • Refactored the account details component for optimized layout and clearer information presentation.
  • Bug Fixes

    • Fixed image URL generation in metadata to correctly use thread IDs, enhancing reliability in content delivery.

Copy link

vercel bot commented Apr 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
masterbots ✅ Ready (Inspect) Visit Preview Apr 14, 2024 6:46am

Copy link
Contributor

coderabbitai bot commented Apr 14, 2024

Walkthrough

The updates across various components and services in the Masterbots.ai project focus on enhancing URL handling, improving UI components, and refining metadata generation. Changes include the introduction of a new utility for slug generation, adjustments in data fetching and display logic in both front-end components and server-side image generation, and a more structured and visually appealing layout in account details.

Changes

File Path Change Summary
.../app/b/[id]/page.tsx Added toSlug import for better URL handling; updated href attribute and UI display of category names.
.../app/og/route.tsx,
.../lib/metadata.ts
Enhanced thread information fetching and image URL generation using threadId; updated image response styling.
.../components/shared/account-details.tsx Added category prop; refactored UI structure and styling; improved display logic for user and chatbot details.

🐰✨📘
In the land of code and pixel sprites,
A rabbit hopped through neon nights.
With each soft paw on silicon sands,
It tweaked the web with gentle hands.
Now URLs flow smooth and sleek,
A tale of bytes that rabbits speak.


Recent Review Details

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between f179424 and 30b6cba.
Files ignored due to path filters (1)
  • bun.lockb is excluded by !bun.lockb
Files selected for processing (4)
  • apps/masterbots.ai/app/b/[id]/page.tsx (3 hunks)
  • apps/masterbots.ai/app/og/route.tsx (1 hunks)
  • apps/masterbots.ai/components/shared/account-details.tsx (2 hunks)
  • apps/masterbots.ai/lib/metadata.ts (1 hunks)
Additional comments not posted (1)
apps/masterbots.ai/lib/metadata.ts (1)

22-22: Ensure threadId is always valid before using it in the OG image URL to prevent broken links.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@gaboesquivel gaboesquivel merged commit f6616c8 into alpha Apr 14, 2024
4 checks passed
@gaboesquivel gaboesquivel deleted the feat-dynamic-og-image branch April 14, 2024 06:47
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 3

Comment on lines +39 to +41
href={`/b/${toSlug(chatbot.name)}`}
threadNum={threads.length}
category={chatbot.categories[0]?.category.name}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ensure chatbot.categories is not empty before accessing it to prevent runtime errors.

- category={chatbot.categories[0]?.category.name}
+ category={chatbot.categories.length > 0 ? chatbot.categories[0].category.name : 'Default Category'}

Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.

Suggested change
href={`/b/${toSlug(chatbot.name)}`}
threadNum={threads.length}
category={chatbot.categories[0]?.category.name}
href={`/b/${toSlug(chatbot.name)}`}
threadNum={threads.length}
category={chatbot.categories.length > 0 ? chatbot.categories[0].category.name : 'Default Category'}

@@ -69,4 +70,5 @@ interface AccountDetailsProps {
threadNum?: number
chatbotName?: string
description?: string
category?: string
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider making the category prop required if it is always expected, to improve type safety and prevent runtime errors.

- category?: string
+ category: string

Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.

Suggested change
category?: string
category: string

try {
const { searchParams } = req.nextUrl
const threadId = searchParams.get('threadId')
const thread = await getThread({ threadId })
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add error handling for cases where thread is null to prevent generating incomplete image responses.

- const thread = await getThread({ threadId })
+ const thread = await getThread({ threadId })
+ if (!thread) return new Response('Thread not found', { status: 404 })

Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.

Suggested change
const thread = await getThread({ threadId })
const thread = await getThread({ threadId })
if (!thread) return new Response('Thread not found', { status: 404 })

Copy link

⚡️ Lighthouse report

Page: https://masterbots-ju76ev5b8-bitcash.vercel.app/
Report https://storage.googleapis.com/lighthouse-infrastructure.appspot.com/reports/1713077710783-8892.report.html

Category Score
🔴 Performance 37
🟢 Accessibility 96
🟠 Best practices 78
🟠 SEO 85
🔴 PWA 38

Page: https://masterbots-ju76ev5b8-bitcash.vercel.app/b/moneybot
Report https://storage.googleapis.com/lighthouse-infrastructure.appspot.com/reports/1713077711431-79358.report.html

Category Score
🟠 Performance 53
🟢 Accessibility 96
🟠 Best practices 78
🟠 SEO 85
🔴 PWA 38

Page: https://masterbots-ju76ev5b8-bitcash.vercel.app/u/slug-1
Report https://storage.googleapis.com/lighthouse-infrastructure.appspot.com/reports/1713077711831-5424.report.html

Category Score
🟠 Performance 59
🟢 Accessibility 94
🟠 Best practices 78
🟠 SEO 83
🔴 PWA 38

Page: https://masterbots-ju76ev5b8-bitcash.vercel.app/p
Report https://storage.googleapis.com/lighthouse-infrastructure.appspot.com/reports/1713077712225-4700.report.html

Category Score
🟠 Performance 57
🟢 Accessibility 92
🟠 Best practices 78
🟠 SEO 76
🔴 PWA 38

Page: https://masterbots-ju76ev5b8-bitcash.vercel.app/health
Report https://storage.googleapis.com/lighthouse-infrastructure.appspot.com/reports/1713077712599-47677.report.html

Category Score
🟠 Performance 58
🟠 Accessibility 59
🟠 Best practices 74
🔴 SEO 42
🔴 PWA 13

Page: https://masterbots-ju76ev5b8-bitcash.vercel.app/health/a8103808-14a3-48ed-aa5a-9e490cfdcf0e
Report https://storage.googleapis.com/lighthouse-infrastructure.appspot.com/reports/1713077712892-13838.report.html

Category Score
🟠 Performance 57
🟠 Accessibility 59
🟠 Best practices 74
🔴 SEO 42
🔴 PWA 13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant