-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: og image with chatbot avatar #179
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
WalkthroughThe updates across various components and services in the Masterbots.ai project focus on enhancing URL handling, improving UI components, and refining metadata generation. Changes include the introduction of a new utility for slug generation, adjustments in data fetching and display logic in both front-end components and server-side image generation, and a more structured and visually appealing layout in account details. Changes
Recent Review DetailsConfiguration used: CodeRabbit UI Files ignored due to path filters (1)
Files selected for processing (4)
Additional comments not posted (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 3
href={`/b/${toSlug(chatbot.name)}`} | ||
threadNum={threads.length} | ||
category={chatbot.categories[0]?.category.name} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ensure chatbot.categories
is not empty before accessing it to prevent runtime errors.
- category={chatbot.categories[0]?.category.name}
+ category={chatbot.categories.length > 0 ? chatbot.categories[0].category.name : 'Default Category'}
Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
href={`/b/${toSlug(chatbot.name)}`} | |
threadNum={threads.length} | |
category={chatbot.categories[0]?.category.name} | |
href={`/b/${toSlug(chatbot.name)}`} | |
threadNum={threads.length} | |
category={chatbot.categories.length > 0 ? chatbot.categories[0].category.name : 'Default Category'} |
@@ -69,4 +70,5 @@ interface AccountDetailsProps { | |||
threadNum?: number | |||
chatbotName?: string | |||
description?: string | |||
category?: string |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider making the category
prop required if it is always expected, to improve type safety and prevent runtime errors.
- category?: string
+ category: string
Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
category?: string | |
category: string |
try { | ||
const { searchParams } = req.nextUrl | ||
const threadId = searchParams.get('threadId') | ||
const thread = await getThread({ threadId }) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add error handling for cases where thread
is null to prevent generating incomplete image responses.
- const thread = await getThread({ threadId })
+ const thread = await getThread({ threadId })
+ if (!thread) return new Response('Thread not found', { status: 404 })
Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
const thread = await getThread({ threadId }) | |
const thread = await getThread({ threadId }) | |
if (!thread) return new Response('Thread not found', { status: 404 }) |
first version of the dynamic og image card, we still need to add dynamic category color. currently fixed to red
related #140
Summary by CodeRabbit
New Features
Refactor
Bug Fixes