Ensure entity instances have unique ids, closes #213 #214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bitbrain
force-pushed
the
ensure-entities-have-unique-ids
branch
from
0ff4f26 to
4bd9f6e
Compare
bitbrain
commented
Nov 30, 2024
| @@ -634,15 +639,19 @@ func is_category(category_id: String) -> bool: | |||
| category = Pandora.get_category(parent_id) | |||
| parent_id = category._category_id | |||
| return false | |||
|
|
|||
|
|
|||
| func get_entity_instance_id() -> String: | |||
There was a problem hiding this comment.
get_instance_id() is already reserved for Godot.
bitbrain
commented
Nov 30, 2024
|
|
||
|
|
||
| ## Initializes this entity with the given data dictionary. | ||
| ## Dictionary needs to confirm the structure of this entity. | ||
| func load_data(data: Dictionary) -> void: | ||
| if data.has("_id"): | ||
| _id = data["_id"] | ||
| if data.has("_instanced_from_id"): |
There was a problem hiding this comment.
This is a breaking change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.