Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/android node networking POC integration #38

Merged

Conversation

rodvar
Copy link
Collaborator

@rodvar rodvar commented Nov 13, 2024

  • Implementation for Integrate full node POC code into Bisq-mobile project #6
  • with this PR the androidNode app is in a state where it shows on screen anything that has been developed in shared adding the below:
    • connects to bisq2 network
    • creates a profile if not created and persisted already
    • observes and logs network information
    • listens for private messaging (this is gonna be our trading mechanism!)
    • listens for public messaging (for chat / not included in the MVP but nice to have)
  • to not over complicate things its left like this for further development on architecture that's coming to happen.

HenrikJannsen and others added 23 commits November 13, 2024 11:10
* Added Koin Dependency

At this stage, have only added in build.gradle.kts file under comman
code.

* Added sample code on android side

* Added di under shared package

* Added Koin under ios

* Fix - Renaming files

* Added Koin to Android Node

* Fix - Reformat the code

* Fix - fomatting again
… service + junit setup and test for the new code
@rodvar rodvar self-assigned this Nov 13, 2024
@rodvar rodvar marked this pull request as ready for review November 13, 2024 03:04
Copy link
Contributor

@HenrikJannsen HenrikJannsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@rodvar rodvar merged commit 66605d1 into bisq-network:main Nov 13, 2024
1 check passed
@rodvar rodvar deleted the feature/android_node_networking_integration branch November 13, 2024 05:15
rodvar added a commit that referenced this pull request Feb 5, 2025
* Remove protobuf files and i18n resources

* Remove mobile package (was first dev app with showing version number)

* Add multidex dependency, add protobuf source path

* - small adaptations on android native POC whilst understanding it

* - convert android native POC code to Kotlin for easier transition

* - replace completable future with coroutines job

* - protobuf fixes on POC merged from boilingfrog, fully communicates with seednode now (thanks Henrik!)

* - integration of last commit into the androidNode

* - integrated services from POC with all their dependencies, ready to be used

* - initialize services, added typesafe conf where its expecting it

* - integration of print default sec key and language, printing on system.out

* Added Koin Dependency (#31)

* Added Koin Dependency

At this stage, have only added in build.gradle.kts file under comman
code.

* Added sample code on android side

* Added di under shared package

* Added Koin under ios

* Fix - Renaming files

* Added Koin to Android Node

* Fix - Reformat the code

* Fix - fomatting again

* - integrated services from POC with all their dependencies, ready to be used

* - hardcode presenter dependency till issues with DI Koin and androidNode gets fixed

* - remove protobuf lite dep causing trouble with protobuf in bisq2 jars on runtime

* - capable of creating profile if non existent and gets persisted

* - observe network changes and log, fetch and print btc market price

* - private messaging (trading) integration

* - public messaging integration

* - Implementation for android node memory report integrated with main service + junit setup and test for the new code

* - android node ci config to use its own presenter as main

* - integration of app state

* - add cleanup on presenter destruction

* - fix userProfile mode package name

---------

Co-authored-by: HenrikJannsen <[email protected]>
Co-authored-by: nis-ship-it <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants