-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/android node networking POC integration #38
Merged
rodvar
merged 24 commits into
bisq-network:main
from
rodvar:feature/android_node_networking_integration
Nov 13, 2024
Merged
Feature/android node networking POC integration #38
rodvar
merged 24 commits into
bisq-network:main
from
rodvar:feature/android_node_networking_integration
Nov 13, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…with seednode now (thanks Henrik!)
* Added Koin Dependency At this stage, have only added in build.gradle.kts file under comman code. * Added sample code on android side * Added di under shared package * Added Koin under ios * Fix - Renaming files * Added Koin to Android Node * Fix - Reformat the code * Fix - fomatting again
… service + junit setup and test for the new code
HenrikJannsen
approved these changes
Nov 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK
rodvar
added a commit
that referenced
this pull request
Feb 5, 2025
* Remove protobuf files and i18n resources * Remove mobile package (was first dev app with showing version number) * Add multidex dependency, add protobuf source path * - small adaptations on android native POC whilst understanding it * - convert android native POC code to Kotlin for easier transition * - replace completable future with coroutines job * - protobuf fixes on POC merged from boilingfrog, fully communicates with seednode now (thanks Henrik!) * - integration of last commit into the androidNode * - integrated services from POC with all their dependencies, ready to be used * - initialize services, added typesafe conf where its expecting it * - integration of print default sec key and language, printing on system.out * Added Koin Dependency (#31) * Added Koin Dependency At this stage, have only added in build.gradle.kts file under comman code. * Added sample code on android side * Added di under shared package * Added Koin under ios * Fix - Renaming files * Added Koin to Android Node * Fix - Reformat the code * Fix - fomatting again * - integrated services from POC with all their dependencies, ready to be used * - hardcode presenter dependency till issues with DI Koin and androidNode gets fixed * - remove protobuf lite dep causing trouble with protobuf in bisq2 jars on runtime * - capable of creating profile if non existent and gets persisted * - observe network changes and log, fetch and print btc market price * - private messaging (trading) integration * - public messaging integration * - Implementation for android node memory report integrated with main service + junit setup and test for the new code * - android node ci config to use its own presenter as main * - integration of app state * - add cleanup on presenter destruction * - fix userProfile mode package name --------- Co-authored-by: HenrikJannsen <[email protected]> Co-authored-by: nis-ship-it <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
androidNode
app is in a state where it shows on screen anything that has been developed in shared adding the below: