Added Koin Dependency #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rodvar
requested changes
Nov 8, 2024
There was a problem hiding this comment.
hey @nis-ship-it thanks for your first contribution!
I've left a comment on the code to review with you.
Also, it would be great if you could also add an example of usage at least of the new libs to be used.
You could for example check how the presenters are being injected in the different main views of each app (e.g. androidClient MainActivity) and replace the current hardcoded instanciation of the depedencies (repository, presenter, etc) you could replace it with the Koin DI
That would help a lot for other devs to copy and start using Koin.
Let me know you thoughts!
|
@rodvar I don't know much on ios side like if we can really call kt code? In this case koin |
thanks @nis-ship-it I'll have a look into this soon ! |
|
@nis-ship-it had the first look and its looking good, some comments here:
|
|
I tried the aliases but it's the same error so dnt knw about that it would work. Forgot about the node side, I will add koin to it |
added 6 commits
November 12, 2024 13:28
At this stage, have only added in build.gradle.kts file under comman code.
rodvar
force-pushed
the
feature/koinInjection
branch
from
a15ee91 to
ecac27e
Compare
|
rebased branch to latest main changes |
rodvar
requested changes
Nov 12, 2024
bisqapps/androidClient/src/androidMain/kotlin/network/bisq/mobile/client/MainApplication.kt
Show resolved
Hide resolved
|
Thanks @nis-ship-it for your first contribution to bisq-mobile! 🎉 Please reach out on matrix if you would like to continue contributing 💪 |
rodvar
pushed a commit
to rodvar/bisq-mobile
that referenced
this pull request
Nov 12, 2024
* Added Koin Dependency At this stage, have only added in build.gradle.kts file under comman code. * Added sample code on android side * Added di under shared package * Added Koin under ios * Fix - Renaming files * Added Koin to Android Node * Fix - Reformat the code * Fix - fomatting again
rodvar
pushed a commit
to rodvar/bisq-mobile
that referenced
this pull request
Nov 13, 2024
* Added Koin Dependency At this stage, have only added in build.gradle.kts file under comman code. * Added sample code on android side * Added di under shared package * Added Koin under ios * Fix - Renaming files * Added Koin to Android Node * Fix - Reformat the code * Fix - fomatting again
rodvar
added a commit
that referenced
this pull request
Nov 13, 2024
* Remove protobuf files and i18n resources * Remove mobile package (was first dev app with showing version number) * Add multidex dependency, add protobuf source path * - small adaptations on android native POC whilst understanding it * - convert android native POC code to Kotlin for easier transition * - replace completable future with coroutines job * - protobuf fixes on POC merged from boilingfrog, fully communicates with seednode now (thanks Henrik!) * - integration of last commit into the androidNode * - integrated services from POC with all their dependencies, ready to be used * - initialize services, added typesafe conf where its expecting it * - integration of print default sec key and language, printing on system.out * Added Koin Dependency (#31) * Added Koin Dependency At this stage, have only added in build.gradle.kts file under comman code. * Added sample code on android side * Added di under shared package * Added Koin under ios * Fix - Renaming files * Added Koin to Android Node * Fix - Reformat the code * Fix - fomatting again * - integrated services from POC with all their dependencies, ready to be used * - hardcode presenter dependency till issues with DI Koin and androidNode gets fixed * - remove protobuf lite dep causing trouble with protobuf in bisq2 jars on runtime * - capable of creating profile if non existent and gets persisted * - observe network changes and log, fetch and print btc market price * - private messaging (trading) integration * - public messaging integration * - Implementation for android node memory report integrated with main service + junit setup and test for the new code * - android node ci config to use its own presenter as main * - integration of app state * - add cleanup on presenter destruction * - fix userProfile mode package name --------- Co-authored-by: HenrikJannsen <[email protected]> Co-authored-by: nis-ship-it <[email protected]>
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added koin dependency under presentation and domain logic.