Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bitcoin address not showing if the app was in the background whilst the other party filled it #181

Closed
rodvar opened this issue Jan 29, 2025 · 4 comments
Assignees
Labels
In Progress iOSClient This issue is applicable ONLY for `iosClient` app Trading issue is related to the core functionality of trading

Comments

@rodvar
Copy link
Collaborator

rodvar commented Jan 29, 2025

Repro frequency: it's random, haven't been able to consistently reproduce.
How to repro:

  1. Take a sell transaction from your device which maker was your desktop.
  2. After filling in your payment details put the app in the background
  3. Switch to your desktop and send the BTC address and confirm payment.
  4. Switch back to your iOS emulator, tap on the notification to get back to the app and observe

ER: you should see the BTC address to pay to and the button to mark trade as done
OR: BTC address is "N/A"

Tech details

this only happens if the app was backgrounded whilst the other party fill in the BTC and confirms payment
Its important to validate if this issue is linked whatsoever to the notifications feature. if it is, one option is to disable that for iOS for the MVP release and bring it back in for the next release complete notifications implementation (See #180)

@rodvar rodvar added iOSClient This issue is applicable ONLY for `iosClient` app Trading issue is related to the core functionality of trading labels Jan 29, 2025
@rodvar rodvar added this to the MVP (version 0.1.0) milestone Jan 29, 2025
@rodvar rodvar self-assigned this Jan 29, 2025
@rodvar rodvar added the hi-prio label Jan 29, 2025
@rodvar
Copy link
Collaborator Author

rodvar commented Jan 30, 2025

not reproducible on android client

@rodvar
Copy link
Collaborator Author

rodvar commented Jan 30, 2025

can't get to repro in iOS either, been trying for a while now. Will leave this open for now to see if we can get it to happen during dev and get the logs

@rodvar rodvar removed the hi-prio label Jan 30, 2025
@rodvar
Copy link
Collaborator Author

rodvar commented Feb 4, 2025

this might have been fully fixed with the fix implemented for #172

@rodvar
Copy link
Collaborator Author

rodvar commented Feb 6, 2025

cannot repro anymore

@rodvar rodvar closed this as completed Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
In Progress iOSClient This issue is applicable ONLY for `iosClient` app Trading issue is related to the core functionality of trading
Projects
None yet
Development

No branches or pull requests

1 participant