Notifications: Ongoing trades

[rodvar]

Follow up for #53

When user has trades ongoing the app need to notify them on every step of the process that needs his attention

• trade started
• payment started
• other end mark trade as completed
• trading chat messages

Use this issue to make sure the notification service is online when trades are ongoing and gets shutdown when there are no ongoing trades

[rodvar]

with the trading protocol implemented and the foundation work this is now ready to be implemented

[rodvar]

Example of phases change ( device Seller & Taker, desktop buyer & maker)

 14914-14914 TradeFlowPresenter      network.bisq.mobile.node.debug       D  Trade State Changed to: TAKER_RECEIVED_TAKE_OFFER_RESPONSE__SELLER_DID_NOT_SENT_ACCOUNT_DATA__SELLER_DID_NOT_RECEIVED_BTC_ADDRESS
  14914-14914 TradeFlowPresenter      network.bisq.mobile.node.debug       D  Trade State Changed to: TAKER_RECEIVED_TAKE_OFFER_RESPONSE__SELLER_SENT_ACCOUNT_DATA__SELLER_DID_NOT_RECEIVED_BTC_ADDRESS
14914-14914 TradeFlowPresenter      network.bisq.mobile.node.debug       D  Trade State Changed to: TAKER_RECEIVED_TAKE_OFFER_RESPONSE__SELLER_SENT_ACCOUNT_DATA__SELLER_RECEIVED_BTC_ADDRESS
  14914-14914 TradeFlowPresenter      network.bisq.mobile.node.debug       D  Trade State Changed to: SELLER_RECEIVED_FIAT_SENT_CONFIRMATION
  14914-14914 TradeFlowPresenter      network.bisq.mobile.node.debug       D  Trade State Changed to: SELLER_CONFIRMED_FIAT_RECEIPT
  14914-14914 TradeFlowPresenter      network.bisq.mobile.node.debug       D  Trade State Changed to: SELLER_SENT_BTC_SENT_CONFIRMATION
  14914-14914 TradeFlowPresenter      network.bisq.mobile.node.debug       D  Trade State Changed to: BTC_CONFIRMED

[HenrikJannsen]

The ChatNotificationService and BisqEasyNotificationsService are the relevant Bisq 2 services for handling notifications. Best to look at the Bisq 2 UI layer code how its used there.

[rodvar]

we have a OsSpecificNotificationService interface with the OsxNotificationService, LinuxNotificationService etc. impl.

maybe it would be enough to add an Android and iOSNotificationService there, to manage the mobile notification handling. not sure if that would be the right path, i would need to get my head deeper into the topic... but at least for desktop thats the way how we apply the OS specifics 

henrik comment to check out (at least for node)

[rodvar]

discussions are ongoing related to this -> #173

[rodvar]

After discussions in both, GH and Mtx we decided to stop efforts on this for the MVP. Outcome as follows:

1. The MVP will have background notifications in place only for open trades , without guarantee that will work in 100% of the cases (e.g. OS kills the app for whatever reason whilst in background) though it should generally work.
2. A new Notifications related issue will be created for the next milestone -> Open Trades & My Offers Persistent Notifications #180
3. Bug Bitcoin address not showing if the app was in the background whilst the other party filled it #181 needs to be solved otherwise turn off notifications for iOS at least