Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sys bio model fixes part 2 #76

Merged
merged 8 commits into from
Oct 4, 2024
Merged

Sys bio model fixes part 2 #76

merged 8 commits into from
Oct 4, 2024

Conversation

CodeByDrescher
Copy link
Collaborator

Fixes more problems found in Sys-bio models, including:

  • Simulations with non-zero output start time
  • Simulations with reaction names containing parenthesis missing from output
  • Simulations using copasi annotations that would ignore certain parameters

Copy link

codecov bot commented Oct 4, 2024

Codecov Report

Attention: Patch coverage is 88.40580% with 8 lines in your changes missing coverage. Please review.

Project coverage is 89.30%. Comparing base (c1fa38c) to head (a635a27).
Report is 9 commits behind head on dev.

Files with missing lines Patch % Lines
biosimulators_copasi/core.py 82.60% 4 Missing ⚠️
biosimulators_copasi/data_model.py 91.30% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev      #76      +/-   ##
==========================================
- Coverage   89.50%   89.30%   -0.21%     
==========================================
  Files           6        6              
  Lines        1029     1047      +18     
==========================================
+ Hits          921      935      +14     
- Misses        108      112       +4     
Flag Coverage Δ
unittests 89.30% <88.40%> (-0.21%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@CodeByDrescher CodeByDrescher reopened this Oct 4, 2024
@CodeByDrescher CodeByDrescher changed the title Sys bio model fixes Sys bio model fixes part 2 Oct 4, 2024
Copy link

sonarqubecloud bot commented Oct 4, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
1 Security Hotspot

See analysis details on SonarCloud

@CodeByDrescher CodeByDrescher merged commit 798e207 into dev Oct 4, 2024
1 of 4 checks passed
@CodeByDrescher CodeByDrescher deleted the sys-bio-model-fixes branch October 4, 2024 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant