Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lint): implement noFloatingPromises rule for reguler async function #4911

Merged
merged 6 commits into from
Jan 23, 2025
Merged

feat(lint): implement noFloatingPromises rule for reguler async function #4911

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
e8e9143
feat(lint): implment no-floating-promises rule for reguler async func…
kaykdm Jan 19, 2025
70e50cc
fix some docs and enable the rule for JavaScript files
kaykdm Jan 20, 2025
a110c4f
rebase onto next
kaykdm Jan 20, 2025
1cb349f
Add test case for non-async function that returns Promise
kaykdm Jan 20, 2025
c9ca841
Add Changelog for noFloatingPromises
kaykdm Jan 21, 2025
3768f87
suggest unsafe-fix only when the expression is in an async function
kaykdm Jan 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/add_the_new_rule_nofloatingpromises.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
cli: minor
---

# Add the new rule [`noFloatingPromises`](https://biomejs.dev/linter/rules/no-floating-promises)
11 changes: 11 additions & 0 deletions crates/biome_cli/src/execute/migrate/eslint_any_rule_to_biome.rs
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

228 changes: 124 additions & 104 deletions crates/biome_configuration/src/analyzer/linter/rules.rs
View file
Open in desktop

Large diffs are not rendered by default.

1 change: 1 addition & 0 deletions crates/biome_diagnostics_categories/src/categories.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,6 +149,7 @@ define_categories! {
"lint/nursery/noDynamicNamespaceImportAccess": "https://biomejs.dev/linter/rules/no-dynamic-namespace-import-access",
"lint/nursery/noEnum": "https://biomejs.dev/linter/rules/no-enum",
"lint/nursery/noExportedImports": "https://biomejs.dev/linter/rules/no-exported-imports",
"lint/nursery/noFloatingPromises": "https://biomejs.dev/linter/rules/no-floating-promises",
"lint/nursery/noGlobalDirnameFilename": "https://biomejs.dev/linter/rules/no-global-dirname-filename",
"lint/nursery/noHeadElement": "https://biomejs.dev/linter/rules/no-head-element",
"lint/nursery/noHeadImportInDocument": "https://biomejs.dev/linter/rules/no-head-import-in-document",
Expand Down
2 changes: 2 additions & 0 deletions crates/biome_js_analyze/src/lint/nursery.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ pub mod no_duplicate_else_if;
pub mod no_dynamic_namespace_import_access;
pub mod no_enum;
pub mod no_exported_imports;
pub mod no_floating_promises;
pub mod no_global_dirname_filename;
pub mod no_head_element;
pub mod no_head_import_in_document;
Expand Down Expand Up @@ -60,6 +61,7 @@ declare_lint_group! {
self :: no_dynamic_namespace_import_access :: NoDynamicNamespaceImportAccess ,
self :: no_enum :: NoEnum ,
self :: no_exported_imports :: NoExportedImports ,
self :: no_floating_promises :: NoFloatingPromises ,
self :: no_global_dirname_filename :: NoGlobalDirnameFilename ,
self :: no_head_element :: NoHeadElement ,
self :: no_head_import_in_document :: NoHeadImportInDocument ,
Expand Down
Loading
Loading