Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(parser,format/html): add CDATA sections #4859

Merged
merged 1 commit into from
Jan 9, 2025
Merged

feat(parser,format/html): add CDATA sections #4859

merged 1 commit into from
Jan 9, 2025

Conversation

dyc3
Copy link
Contributor

@dyc3 dyc3 commented Jan 8, 2025

Summary

This adds parsing and basic formatting support for CDATA sections.

Ref: https://html.spec.whatwg.org/multipage/syntax.html#cdata-sections

Test Plan

Added tests, CI should pass.

@github-actions github-actions bot added A-Parser Area: parser A-Formatter Area: formatter A-Tooling Area: internal tools L-HTML Language: HTML labels Jan 8, 2025
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Jan 8, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #4859 will not alter performance

Comparing html-cdata (d2e7696) with next (016046e)

Summary

✅ 95 untouched benchmarks

@dyc3 dyc3 merged commit 1edc35f into next Jan 9, 2025
11 checks passed
@dyc3 dyc3 deleted the html-cdata branch January 9, 2025 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ematipico ematipico ematipico approved these changes

Assignees
No one assigned
Labels
A-Formatter Area: formatter A-Parser Area: parser A-Tooling Area: internal tools L-HTML Language: HTML
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dyc3 @ematipico