feat(analyzer): assists

.gitattributes

@@ -4,19 +4,30 @@
 /crates/biome_cli/src/execute/migrate/eslint_any_rule_to_biome.rs linguist-generated=true text=auto eol=lf
 /crates/biome_configuration/src/generated.rs linguist-generated=true text=auto eol=lf
 /crates/biome_configuration/src/linter/rules.rs linguist-generated=true text=auto eol=lf
+/crates/biome_configuration/src/assists/rules.rs linguist-generated=true text=auto eol=lf
 /crates/biome_configuration/src/parse/json/rules.rs linguist-generated=true text=auto eol=lf
-/crates/biome_css_analyze/src/lint.rs linguist-generated=true text=auto eol=lf
-/crates/biome_css_analyze/src/lint/*.rs linguist-generated=true text=auto eol=lf
+# GraphQL
+/crates/biome_graphql_analyze/src/{lint,assists,syntax}.rs linguist-generated=true text=auto eol=lf
+/crates/biome_graphql_analyze/src/{lint,assists,syntax}/*.rs linguist-generated=true text=auto eol=lf
+/crates/biome_graphql_analyze/src/options.rs linguist-generated=true text=auto eol=lf
+/crates/biome_graphql_analyze/src/registry.rs linguist-generated=true text=auto eol=lf
+# CSS
+/crates/biome_css_analyze/src/{lint,assists,syntax}.rs linguist-generated=true text=auto eol=lf
+/crates/biome_css_analyze/src/{lint,assists,syntax}/*.rs linguist-generated=true text=auto eol=lf
 /crates/biome_css_analyze/src/options.rs linguist-generated=true text=auto eol=lf
 /crates/biome_css_analyze/src/registry.rs linguist-generated=true text=auto eol=lf
-/crates/biome_js_analyze/src/assists.rs linguist-generated=true text=auto eol=lf
-/crates/biome_js_analyze/src/assists/*.rs linguist-generated=true text=auto eol=lf
-/crates/biome_js_analyze/src/lint.rs linguist-generated=true text=auto eol=lf
-/crates/biome_js_analyze/src/lint/*.rs linguist-generated=true text=auto eol=lf
+# JSON
+/crates/biome_json_analyze/src/{lint,assists,syntax}.rs linguist-generated=true text=auto eol=lf
+/crates/biome_json_analyze/src/{lint,assists,syntax}/*.rs linguist-generated=true text=auto eol=lf
 /crates/biome_js_analyze/src/options.rs linguist-generated=true text=auto eol=lf
 /crates/biome_js_analyze/src/registry.rs linguist-generated=true text=auto eol=lf
-/crates/biome_js_analyze/src/syntax.rs linguist-generated=true text=auto eol=lf
-/crates/biome_js_analyze/src/syntax/*.rs linguist-generated=true text=auto eol=lf
+# JS
+/crates/biome_js_analyze/src/{lint,assists,syntax}.rs linguist-generated=true text=auto eol=lf
+/crates/biome_js_analyze/src/{lint,assists,syntax}/*.rs linguist-generated=true text=auto eol=lf
+/crates/biome_js_analyze/src/options.rs linguist-generated=true text=auto eol=lf
+/crates/biome_js_analyze/src/registry.rs linguist-generated=true text=auto eol=lf
+
+# Other
 /crates/biome_unicode_table/src/tables.rs linguist-generated=true text=auto eol=lf
 /packages/@biomejs/backend-jsonrpc/src/workspace.ts linguist-generated=true text=auto eol=lf
 /packages/@biomejs/biome/configuration_schema.json linguist-generated=true text=auto eol=lf

biome.json

@@ -1,5 +1,21 @@
 {
   "$schema": "./packages/@biomejs/biome/configuration_schema.json",
+  "assists": {
+    "enabled": true,
+    "ignore": [
+      "./packages/@biomejs/biome/configuration_schema.json"
+    ],
+    "actions": {
+      "source": {
+        "useSortedKeys": "off"
+      }
+    }
+  },
+  "css": {
+    "linter": {
+      "enabled": true
+    }
+  },
   "files": {
     "ignore": [
       "crates/**",
@@ -29,11 +45,6 @@
       "lineWidth": 1
     }
   },
-  "vcs": {
-    "clientKind": "git",
-    "enabled": true,
-    "useIgnoreFile": true
-  },
   "linter": {
     "enabled": true,
     "rules": {
@@ -45,5 +56,10 @@
   },
   "organizeImports": {
     "enabled": true
+  },
+  "vcs": {
+    "clientKind": "git",
+    "enabled": true,
+    "useIgnoreFile": true
   }
 }

crates/biome_analyze/src/rule.rs

@@ -494,7 +494,7 @@ macro_rules! declare_rule {
 /// Check [crate](module documentation) for a better
 /// understanding of how the macro works
 #[macro_export]
-macro_rules! declare_refactor_rule {
+macro_rules! declare_source_rule {
     ( $( #[doc = $doc:literal] )+ $vis:vis $id:ident {
         version: $version:literal,
         name: $name:tt,
@@ -515,7 +515,7 @@ macro_rules! declare_refactor_rule {
         /// This macro returns the corresponding [ActionCategory] to use inside the [RuleAction]
         #[allow(unused_macros)]
         macro_rules! rule_action_category {
-            () => { ActionCategory::Refactor(RefactorKind::Other(Cow::Borrowed(concat!($language, ".", $name) )))  };
+            () => { ActionCategory::Source(SourceActionKind::Other(Cow::Borrowed(concat!($language, ".", $name) )))  };
         }
     };
 }

crates/biome_cli/src/commands/check.rs

@@ -6,6 +6,7 @@ use crate::execute::VcsTargeted;
 use crate::{
     execute_mode, setup_cli_subscriber, CliDiagnostic, CliSession, Execution, TraversalMode,
 };
+use biome_configuration::analyzer::assists::PartialAssistsConfiguration;
 use biome_configuration::{
     organize_imports::PartialOrganizeImports, PartialConfiguration, PartialFormatterConfiguration,
     PartialLinterConfiguration,
@@ -36,6 +37,7 @@ pub(crate) struct CheckCommandPayload {
     pub(crate) formatter_enabled: Option<bool>,
     pub(crate) linter_enabled: Option<bool>,
     pub(crate) organize_imports_enabled: Option<bool>,
+    pub(crate) assists_enabled: Option<bool>,
     pub(crate) staged: bool,
     pub(crate) changed: bool,
     pub(crate) since: Option<String>,
@@ -60,6 +62,7 @@ pub(crate) fn check(
         organize_imports_enabled,
         formatter_enabled,
         since,
+        assists_enabled,
         staged,
         changed,
     } = payload;
@@ -148,6 +151,14 @@ pub(crate) fn check(
         organize_imports.enabled = organize_imports_enabled;
     }
 
+    let assists = fs_configuration
+        .assists
+        .get_or_insert_with(PartialAssistsConfiguration::default);
+
+    if assists_enabled.is_some() {
+        assists.enabled = assists_enabled;
+    }
+
     if let Some(mut configuration) = configuration {
         if let Some(linter) = configuration.linter.as_mut() {
             // Don't overwrite rules from the CLI configuration.

crates/biome_cli/src/commands/ci.rs

@@ -3,6 +3,7 @@ use crate::cli_options::CliOptions;
 use crate::commands::{resolve_manifest, validate_configuration_diagnostics};
 use crate::execute::VcsTargeted;
 use crate::{execute_mode, setup_cli_subscriber, CliDiagnostic, CliSession, Execution};
+use biome_configuration::analyzer::assists::PartialAssistsConfiguration;
 use biome_configuration::{organize_imports::PartialOrganizeImports, PartialConfiguration};
 use biome_configuration::{PartialFormatterConfiguration, PartialLinterConfiguration};
 use biome_deserialize::Merge;
@@ -16,6 +17,7 @@ pub(crate) struct CiCommandPayload {
     pub(crate) formatter_enabled: Option<bool>,
     pub(crate) linter_enabled: Option<bool>,
     pub(crate) organize_imports_enabled: Option<bool>,
+    pub(crate) assists_enabled: Option<bool>,
     pub(crate) paths: Vec<OsString>,
     pub(crate) configuration: Option<PartialConfiguration>,
     pub(crate) cli_options: CliOptions,
@@ -30,6 +32,7 @@ pub(crate) fn ci(session: CliSession, payload: CiCommandPayload) -> Result<(), C
         formatter_enabled,
         linter_enabled,
         organize_imports_enabled,
+        assists_enabled,
         configuration,
         mut paths,
         since,
@@ -76,6 +79,14 @@ pub(crate) fn ci(session: CliSession, payload: CiCommandPayload) -> Result<(), C
         organize_imports.enabled = organize_imports_enabled;
     }
 
+    let assists = fs_configuration
+        .assists
+        .get_or_insert_with(PartialAssistsConfiguration::default);
+
+    if assists_enabled.is_some() {
+        assists.enabled = assists_enabled;
+    }
+
     // no point in doing the traversal if all the checks have been disabled
     if fs_configuration.is_formatter_disabled()
         && fs_configuration.is_linter_disabled()

crates/biome_cli/src/commands/lint.rs

@@ -6,10 +6,10 @@ use crate::execute::VcsTargeted;
 use crate::{
     execute_mode, setup_cli_subscriber, CliDiagnostic, CliSession, Execution, TraversalMode,
 };
+use biome_configuration::analyzer::RuleSelector;
 use biome_configuration::css::PartialCssLinter;
 use biome_configuration::javascript::PartialJavascriptLinter;
 use biome_configuration::json::PartialJsonLinter;
-use biome_configuration::linter::RuleSelector;
 use biome_configuration::vcs::PartialVcsConfiguration;
 use biome_configuration::{
     PartialConfiguration, PartialFilesConfiguration, PartialGraphqlLinter,

crates/biome_cli/src/commands/mod.rs

@@ -4,10 +4,10 @@ use crate::diagnostics::{DeprecatedArgument, DeprecatedConfigurationFile};
 use crate::execute::Stdin;
 use crate::logging::LoggingKind;
 use crate::{CliDiagnostic, CliSession, LoggingLevel, VERSION};
+use biome_configuration::analyzer::RuleSelector;
 use biome_configuration::css::PartialCssLinter;
 use biome_configuration::javascript::PartialJavascriptLinter;
 use biome_configuration::json::PartialJsonLinter;
-use biome_configuration::linter::RuleSelector;
 use biome_configuration::{
     css::partial_css_formatter, css::partial_css_linter, graphql::partial_graphql_formatter,
     graphql::partial_graphql_linter, javascript::partial_javascript_formatter,
@@ -120,6 +120,11 @@ pub enum BiomeCommand {
             hide_usage
         )]
         organize_imports_enabled: Option<bool>,
+
+        /// Allow to enable or disable the assists.
+        #[bpaf(long("assists-enabled"), argument("true|false"), optional)]
+        assists_enabled: Option<bool>,
+
         #[bpaf(external(partial_configuration), hide_usage, optional)]
         configuration: Option<PartialConfiguration>,
         #[bpaf(external, hide_usage)]
@@ -312,6 +317,10 @@ pub enum BiomeCommand {
         #[bpaf(long("organize-imports-enabled"), argument("true|false"), optional)]
         organize_imports_enabled: Option<bool>,
 
+        /// Allow to enable or disable the assists.
+        #[bpaf(long("assists-enabled"), argument("true|false"), optional)]
+        assists_enabled: Option<bool>,
+
         #[bpaf(external(partial_configuration), hide_usage, optional)]
         configuration: Option<PartialConfiguration>,
         #[bpaf(external, hide_usage)]

crates/biome_cli/src/execute/diagnostics.rs

@@ -29,6 +29,17 @@ pub(crate) struct CIOrganizeImportsDiffDiagnostic {
     #[advice]
     pub(crate) diff: ContentDiffAdvice,
 }
+#[derive(Debug, Diagnostic)]
+#[diagnostic(
+    category = "assists",
+    message = "Applied assists differs from the output"
+)]
+pub(crate) struct CIAssistsDiffDiagnostic {
+    #[location(resource)]
+    pub(crate) file_name: String,
+    #[advice]
+    pub(crate) diff: ContentDiffAdvice,
+}
 
 #[derive(Debug, Diagnostic)]
 #[diagnostic(
@@ -56,6 +67,19 @@ pub(crate) struct OrganizeImportsDiffDiagnostic {
     pub(crate) diff: ContentDiffAdvice,
 }
 
+#[derive(Debug, Diagnostic)]
+#[diagnostic(
+    category = "assists",
+    severity = Error,
+    message = "Not all assists were applied:"
+)]
+pub(crate) struct AssistsDiffDiagnostic {
+    #[location(resource)]
+    pub(crate) file_name: String,
+    #[advice]
+    pub(crate) diff: ContentDiffAdvice,
+}
+
 #[derive(Debug, Diagnostic)]
 #[diagnostic(
 	category = "migrate",

crates/biome_cli/src/execute/mod.rs

@@ -15,7 +15,7 @@ use crate::reporter::junit::{JunitReporter, JunitReporterVisitor};
 use crate::reporter::summary::{SummaryReporter, SummaryReporterVisitor};
 use crate::reporter::terminal::{ConsoleReporter, ConsoleReporterVisitor};
 use crate::{CliDiagnostic, CliSession, DiagnosticsPayload, Reporter};
-use biome_configuration::linter::RuleSelector;
+use biome_configuration::analyzer::RuleSelector;
 use biome_console::{markup, ConsoleExt};
 use biome_diagnostics::adapters::SerdeJsonError;
 use biome_diagnostics::{category, Category};
@@ -69,6 +69,7 @@ impl Execution {
                 .with_organize_imports()
                 .with_formatter()
                 .with_linter()
+                .with_assists()
                 .build(),
             TraversalMode::Migrate { .. } => FeatureName::empty(),
             TraversalMode::Search { .. } => FeaturesBuilder::new().with_search().build(),

crates/biome_cli/src/execute/process_file.rs

@@ -1,3 +1,4 @@
+mod assists;
 mod check;
 mod format;
 mod lint;
@@ -71,6 +72,7 @@ impl Message {
 pub(crate) enum DiffKind {
     Format,
     OrganizeImports,
+    Assists,
 }
 
 impl<D> From<D> for Message

crates/biome_cli/src/execute/process_file/assists.rs

@@ -0,0 +1,72 @@
+use crate::execute::diagnostics::ResultExt;
+use crate::execute::process_file::workspace_file::WorkspaceFile;
+use crate::execute::process_file::{
+    DiffKind, FileResult, FileStatus, Message, SharedTraversalOptions,
+};
+use biome_analyze::RuleCategoriesBuilder;
+use biome_diagnostics::category;
+use biome_service::file_handlers::{AstroFileHandler, SvelteFileHandler, VueFileHandler};
+use biome_service::workspace::FixFileMode;
+
+/// Lints a single file and returns a [FileResult]
+pub(crate) fn assists_with_guard<'ctx>(
+    ctx: &'ctx SharedTraversalOptions<'ctx, '_>,
+    workspace_file: &mut WorkspaceFile,
+) -> FileResult {
+    tracing::info_span!("Processes assists", path =? workspace_file.path.display()).in_scope(
+        move || {
+            let input = workspace_file.input()?;
+            let only = Vec::new();
+            let skip = Vec::new();
+            let fix_result = workspace_file
+                .guard()
+                .fix_file(
+                    FixFileMode::SafeFixes,
+                    false,
+                    RuleCategoriesBuilder::default().with_action().build(),
+                    only.clone(),
+                    skip.clone(),
+                )
+                .with_file_path_and_code(
+                    workspace_file.path.display().to_string(),
+                    category!("assists"),
+                )?;
+
+            ctx.push_message(Message::SkippedFixes {
+                skipped_suggested_fixes: fix_result.skipped_suggested_fixes,
+            });
+
+            let mut output = fix_result.code;
+
+            match workspace_file.as_extension() {
+                Some("astro") => {
+                    output = AstroFileHandler::output(input.as_str(), output.as_str());
+                }
+                Some("vue") => {
+                    output = VueFileHandler::output(input.as_str(), output.as_str());
+                }
+                Some("svelte") => {
+                    output = SvelteFileHandler::output(input.as_str(), output.as_str());
+                }
+                _ => {}
+            }
+            if input != output {
+                if ctx.execution.as_fix_file_mode().is_none() {
+                    return Ok(FileStatus::Message(Message::Diff {
+                        file_name: workspace_file.path.display().to_string(),
+                        old: input,
+                        new: output,
+                        diff_kind: DiffKind::Assists,
+                    }));
+                } else {
+                    if output != input && ctx.execution.as_fix_file_mode().is_some() {
+                        workspace_file.update_file(output)?;
+                    }
+                    Ok(FileStatus::Changed)
+                }
+            } else {
+                Ok(FileStatus::Unchanged)
+            }
+        },
+    )
+}