Add test case for non-async function that returns Promise

biomejs · Jan 22, 2025 · 1cb349f · 1cb349f
1 parent a110c4f
commit 1cb349f
Show file tree

Hide file tree

Showing 2 changed files with 32 additions and 0 deletions.
diff --git a/crates/biome_js_analyze/tests/specs/nursery/noFloatingPromises/invalid.ts b/crates/biome_js_analyze/tests/specs/nursery/noFloatingPromises/invalid.ts
@@ -3,3 +3,11 @@ async function returnsPromise(): Promise<string> {
 }
 returnsPromise();
 returnsPromise().then(() => { }).finally(() => { });
+
+
+function returnsPromiseWithoutAsync(): Promise<string> {
+  return Promise.resolve("value")
+}
+
+
+returnsPromiseWithoutAsync()
diff --git a/crates/biome_js_analyze/tests/specs/nursery/noFloatingPromises/invalid.ts.snap b/crates/biome_js_analyze/tests/specs/nursery/noFloatingPromises/invalid.ts.snap
@@ -10,6 +10,13 @@ async function returnsPromise(): Promise<string> {
 returnsPromise();
 returnsPromise().then(() => { }).finally(() => { });
 
+
+function returnsPromiseWithoutAsync(): Promise<string> {
+  return Promise.resolve("value")
+}
+
+
+returnsPromiseWithoutAsync()
 ```
 
 # Diagnostics
@@ -53,3 +60,20 @@ invalid.ts:5:1 lint/nursery/noFloatingPromises  FIXABLE  ━━━━━━━
       │ ++++++                                                    
 
 ```
+
+```
+invalid.ts:13:1 lint/nursery/noFloatingPromises  FIXABLE  ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
+
+  ! A "floating" Promise was found, meaning it is not properly handled and could lead to ignored errors or unexpected behavior.
+  
+  > 13 │ returnsPromiseWithoutAsync()
+       │ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
+  
+  i This happens when a Promise is not awaited, lacks a `.catch` or `.then` rejection handler, or is not explicitly ignored using the `void` operator.
+  
+  i Safe fix: Add await operator.
+  
+    13 │ await·returnsPromiseWithoutAsync()
+       │ ++++++                            
+
+```