Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use .exe extension for Windows platform #49

Merged
merged 1 commit into from
Oct 4, 2024

Conversation

jackTabsCode
Copy link
Contributor

Closes #48
Not tested because I can't seem to get installing dev extensions to work on Windows.

@jackTabsCode jackTabsCode changed the title Use .exe extension for Windows platform fix: use .exe extension for Windows platform Oct 4, 2024
@ematipico ematipico merged commit e7e3a8c into biomejs:main Oct 4, 2024
4 checks passed
@jackTabsCode jackTabsCode deleted the windows-exe branch October 4, 2024 21:12
@ramipellumbi
Copy link

ramipellumbi commented Oct 18, 2024

Biome fails to start on windows and this would be a huge addition. To get it to work on windows you need to install cmake (recent change to building) and have it in path. See: https://zed.dev/docs/development/windows

An issue on windows now is (with config path set manually to be correct)

Language server error: biome

failed to spawn command. path: "C:Users\\RamiPellumbi\\Documents\\code\\project\\node_modules\\@biomejs\\biome\\bin\\biome", working directory: "C:\\Users\\RamiPellumbi\\Documents\\code\\project", args: ["lsp-proxy"]
-- stderr--

Note the missing \\ after C:. I think this would be an awesome fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fails to start on Windows
3 participants