Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Q2 summary interval allow float #108
ENH: Q2 summary interval allow float #108
Changes from 6 commits
df54ebc
ec5b3de
fab8ddb
cfb757c
d7448b7
e41120f
a3f49b6
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like this line (as well as a few others towards the end of this function, e.g. the
npt.assert_allclose
lines) were taken fromtest_fit()
in this file. That's not a problem, but this should be commented to make that clear if possible -- theclr(clr_inv())
stuff in particular is apparently kind of a hack, and we should try to document where it's used so it could ideally be taken care of in the future.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was gonna ask you to use a more specific error type than just
Exception
but I tried it out and, yep, you get a basicException
when transformations fail. The more you know!(Maaybe worth adding a comment mentioning this just so that future people reviewing this code don't have the same reaction I just did...)