BUG: Problem updating color in circular layout #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Setting the color and switching between layouts would work just fine. However, setting the color once in the circular layout would make the browser tab crash. Seems to be related to to the line width not being parsed correctly.
|
Interesting, I think their might have been some kind of "race" condition where the line width input box was invalid and was not set before the update function was called. So, the line width value was undefined. I'll be able to confirm once I get #142. |
|
Thanks @kwcantrell! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting the color and switching between layouts would work just fine.
However, setting the color once in the circular layout would make the
browser tab crash. Seems to be related to to the line width not being parsed
correctly.