Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Animation #146
Animation #146
Changes from 72 commits
d992b88
c6cc202
3714011
78f2383
476b555
d930e75
790129a
3c9b2fa
9044382
5c686cc
8e4ac07
bcabaab
4b26046
fbf8ece
6db1d0c
7e68666
029f7b3
e53a9a6
1f38def
ffdaaec
41314c3
ef59362
a04ae25
81157ba
40fb511
08622f1
9e574b9
88df7b4
15d7407
e31bbd4
d3a837c
8d59e91
d061f2c
5558099
8abc73e
712585d
25c7a4f
07e967c
c6d6e03
78a6222
0e5701c
67cbccc
823c0d6
3552adf
87d3223
3f33a4d
7d087a1
81f2e9d
cf74095
d097389
576d7b6
2061e91
6ce0cc9
8403e81
8217863
f274b1e
b2ded8c
f0a0f95
4d2b051
02fc054
ee93619
b2d7929
bc52acc
15c0499
2795510
23f8095
19fdbc5
4ee966f
9a92ae1
e478628
ef7daa0
4ff2664
262374f
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In my opinion at least :), it would be nice to have the prev/next-frame buttons present from the start of the animation -- it wasn't clear to me initially that these buttons were even available until I pressed
Pause
. For users who want to step through the animations at their own pace (either to go slower or faster), I suspect these buttons will be preferable.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fedarko thanks for the suggestion! My goal with the GUI is to make things as intuitive and easy to use. One way I try to accomplish this is by only presenting options to the user that can be applied at that moment. Since the prev/next features can only be used when the animation is paused, I decided to hide those options unless the user pauses the animation.
Instead of hiding those buttons, I can disable them while the animation is running and enable them when the animation is paused. Also, I can start the animation is the pause state instead of the run state so users who wanted to manually step through the animation could do so without having to first pause the animation first.
@ElDeveloper how does Emperor handle this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In emperor we disable the buttons and still leave them visible (instead of hiding them).