Refactor to use net.IP as pointer

Also removes generated tests

protocols/ospf/packetv3/common.go

@@ -64,11 +64,11 @@ type deserializableIP struct {
 	Lower  uint64
 }
 
-func (ip deserializableIP) ToNetIP() net.IP {
-	return *(net.IPv6(ip.Higher, ip.Lower))
+func (ip deserializableIP) ToNetIP() *net.IP {
+	return net.IPv6(ip.Higher, ip.Lower)
 }
 
-func serializeIPv6(ip net.IP, buf *bytes.Buffer) {
+func serializeIPv6(ip *net.IP, buf *bytes.Buffer) {
 	if ip.IsIPv4() {
 		for i := 0; i < 16; i++ {
 			buf.WriteByte(0)

protocols/ospf/packetv3/lsa.go

@@ -366,9 +366,9 @@ type ASExternalLSA struct {
 	Metric InterfaceMetric
 	Prefix LSAPrefix
 
-	ForwardingAddress     net.IP // optional
-	ExternalRouteTag      uint32 // optional
-	ReferencedLinkStateID ID     // optional
+	ForwardingAddress     *net.IP // optional
+	ExternalRouteTag      uint32  // optional
+	ReferencedLinkStateID ID      // optional
 }
 
 func (a *ASExternalLSA) FlagE() bool {
@@ -454,7 +454,7 @@ func DeserializeASExternalLSA(buf *bytes.Buffer) (*ASExternalLSA, int, error) {
 type LinkLSA struct {
 	RouterPriority            uint8
 	Options                   RouterOptions
-	LinkLocalInterfaceAddress net.IP
+	LinkLocalInterfaceAddress *net.IP
 	PrefixNum                 uint32
 	Prefixes                  []LSAPrefix
 }

protocols/ospf/packetv3/packet_test.go

@@ -5,13 +5,10 @@ import (
 	"fmt"
 	"io"
 	"os"
-	"path/filepath"
 	"testing"
 
 	ospf "github.com/bio-routing/bio-rd/protocols/ospf/packetv3"
 	"github.com/bio-routing/bio-rd/protocols/ospf/packetv3/fixtures"
-	"github.com/bio-routing/bio-rd/protocols/ospf/packetv3/fixtures/packets"
-	"github.com/stretchr/testify/assert"
 )
 
 var files = []string{
@@ -69,48 +66,3 @@ func testDecodeFile(t *testing.T, path string) {
 		packetCount++
 	}
 }
-
-func TestEncode(t *testing.T) {
-	for _, path := range files {
-		t.Run(path, func(t *testing.T) {
-			testEncodeFile(t, dir+path)
-		})
-	}
-}
-
-func testEncodeFile(t *testing.T, path string) {
-	fmt.Printf("Testing on file: %s\n", path)
-	r, f := fixtures.PacketReader(t, path)
-	defer f.Close()
-
-	packets, ok := packets.Packets[filepath.Base(path)]
-	if !ok {
-		t.Errorf("Raw Go values not found for file %s", filepath.Base(path))
-	}
-
-	var packetCount int
-	for {
-		data, _, err := r.ReadPacketData()
-		if err == io.EOF {
-			break
-		}
-		if err != nil {
-			t.Error(err)
-			return
-		}
-
-		pl, src, dst, err := fixtures.Payload(data)
-		if err != nil {
-			t.Error(err)
-			return
-		}
-
-		t.Run(fmt.Sprintf("Packet_%03d", packetCount+1), func(t *testing.T) {
-			buf := &bytes.Buffer{}
-			msg := packets[packetCount]
-			msg.Serialize(buf, src, dst)
-			assert.Equal(t, buf.Bytes(), pl)
-		})
-		packetCount++
-	}
-}