Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add skip_using_gcc_brace_groups #57

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

skaji
Copy link
Contributor

@skaji skaji commented Jan 27, 2022

As described in Perl/perl5#18780, perl 5.35.1 or below emits a lot of warnings on clang 12+.
This has been fixed in Perl/perl5#18984 and this PR imports the fix into Devel::PatchPerl too.

Notes

  • Although only clang 12+ needs this fix, I don't add any conditions as PR 18984
  • While PR 18984 and this commit also patch Devel::PPPort, I don't patch Devel::PPPort in this PR.
    Devel::PPPort is a CPAN module, so we can upgrade it whenever we want.

@skaji skaji force-pushed the skip_using_gcc_brace_groups branch from ef45eb3 to 99a0216 Compare January 27, 2022 17:46
@skaji skaji closed this Oct 22, 2023
@bingos
Copy link
Owner

bingos commented Jun 25, 2024

I totally missed this sorry. I am suffering a lot of pain provisioning FreeBSD CPAN smokers with all the clang warnings.

I'll reopen as a reminder to myself to, but I shall probably redefine the patches as base64.

Thank you for doing all the heavy lifting on this.

@bingos bingos reopened this Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants