Merge pull request #142 from bindable-ui/km/value_converter_99

Allow SecondsToHmsValueConverter to overflow past 99 hours
bindable-ui · Jun 23, 2022 · d01b08b · d01b08b
2 parents 8a5e0c4 + 329c130
commit d01b08b
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 4 deletions.
diff --git a/src/value-converters/datetime.test.ts b/src/value-converters/datetime.test.ts
@@ -51,8 +51,8 @@ describe('Datetime Value Converter', () => {
             expect(component.toView(33 * 60 * 60)).toEqual('33:00:00');
         });
 
-        it('should not exceed 99 hours', () => {
-            expect(component.toView(100 * 60 * 60)).toEqual('99:00:00');
+        it('should exceed 99 hours', () => {
+            expect(component.toView(100 * 60 * 60)).toEqual('100:00:00');
         });
 
         it('should account for null or undefined', () => {

diff --git a/src/value-converters/datetime.ts b/src/value-converters/datetime.ts
@@ -75,8 +75,6 @@ export class SecondsToHmsValueConverter {
 
         if (hoursDisplay.length === 1) {
             hoursDisplay = `0${hours}`;
-        } else if (hoursDisplay.length > 2) {
-            hoursDisplay = '99';
         }
 
         if (minutesDisplay.length === 1) {