Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset session_id after 14 days #699

Merged
merged 3 commits into from
Dec 1, 2024

Conversation

rikroe
Copy link
Member

@rikroe rikroe commented Dec 1, 2024

Proposed change

Resets session_id after 14 days to net keep the same for longer.

Also adds a test to verify that the CLI oauth_store file is saved even if an error occurs.

Type of change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality to this library)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:

Checklist

  • The code change is tested and works locally.
  • Tests have been added to verify that the new code works.

@rikroe rikroe merged commit e0076ad into bimmerconnected:master Dec 1, 2024
12 checks passed
@rikroe rikroe deleted the cli-refactor-oauth-store branch December 25, 2024 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant