Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PHP ~8.4.0 support #44

Merged
merged 4 commits into from
Dec 4, 2024
Merged

Add PHP ~8.4.0 support #44

merged 4 commits into from
Dec 4, 2024

Conversation

graydav1
Copy link
Contributor

@graydav1 graydav1 commented Dec 4, 2024

Description

Adds PHP 8.4.x support.

Does this close any currently open issues?

Fixes #42

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Any relevant logs, error output, etc?

...

Any other comments?

...

Checklist

  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@bilfeldt bilfeldt self-requested a review December 4, 2024 13:11
Copy link
Owner

@bilfeldt bilfeldt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍 Just added testing.

@bilfeldt bilfeldt mentioned this pull request Dec 4, 2024
@bilfeldt bilfeldt merged commit 55e7e22 into bilfeldt:main Dec 4, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PHP 8.4 unsupported
2 participants