Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: STRF-11523 Enable dynamic partials #1248

Merged
merged 1 commit into from
Dec 18, 2024
Merged

fix: STRF-11523 Enable dynamic partials #1248

merged 1 commit into from
Dec 18, 2024

Conversation

jairo-bc
Copy link
Contributor

@jairo-bc jairo-bc commented Dec 17, 2024

What?

Fixed regex that allows to add partials with syntax {{#> components/ul }}

Tickets / Documentation

Screenshots (if appropriate)

Screenshot 2024-12-16 at 18 42 21 Screenshot 2024-12-16 at 18 42 24

QA Steps:

  1. Get ready to run stencil start (load theme locally, stencil init, etc.)
  2. Run stencil start
  3. Create a similiar structure of components like [here](https://github.com/bigcommerce/stencil-cli/blob/master/test/_mocks/themes/valid/templates/components/c.html, here, here and here
  4. Observe that list successfully rendered in the browser

cc @bigcommerce/storefront-team

@jairo-bc jairo-bc requested a review from a team December 17, 2024 15:29
Copy link
Contributor

@jmwiese jmwiese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bc-max
Copy link
Contributor

bc-max commented Dec 18, 2024

@jairo-bc I see this error in a terminal when running stencil locally (node 20):

Error: The following template(s) are/is missing: 
components/li
components/li
components/li
components/ul
    at file:///.../stencil-cli/lib/template-assembler.js:121:17
    at wrapper (/.../stencil-cli/node_modules/async/dist/async.js:272:20)
    at iteratorCallback (/.../stencil-cli/node_modules/async/dist/async.js:502:17)
    at /.../stencil-cli/node_modules/async/dist/async.js:328:20
    at wrapper (/.../stencil-cli/node_modules/async/dist/async.js:272:20)
    at iteratorCallback (/.../stencil-cli/node_modules/async/dist/async.js:502:17)
    at /.../stencil-cli/node_modules/async/dist/async.js:328:20
    at ReadFileContext.<anonymous> (file:///.../stencil-cli/lib/template-assembler.js:139:17)
    at ReadFileContext.callback (/.../stencil-cli/node_modules/graceful-fs/graceful-fs.js:123:16)
    at FSReqCallback.readFileAfterOpen [as oncomplete] (node:fs:299:13)

@jairo-bc
Copy link
Contributor Author

@bc-max did you create it? I just updated the description for all necessary components to have

Copy link
Contributor

@bc-max bc-max left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💚

image

@bc-max bc-max unassigned bc-jz and bc-max Dec 18, 2024
@jairo-bc jairo-bc merged commit 4fab613 into master Dec 18, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants