Update region.js - Proposal for flags empty
and raw
#338
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added proposal parameters for a variance in the return state of the region block helper.
empty
: When theempty
flag is truthy, if there is no content currently available for the named region; then return a empty string instead of the normal div wrapper.raw
: When theraw
flag is truthy, omit the normal div wrapper when returning the region content.What? Why?
Because empty region blocks add extra HTML into rendered content resulting in the CSS for selectors needing to pass through a additional div before they can trigger. Example of :empty selector.
https://developer.mozilla.org/en-US/docs/Web/CSS/:empty
How was it tested?
Not tested due to no testing protocol found in repo.
cc @bigcommerce/storefront-team