Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: import 3p helpers, introduce webpack to build a single js file #166

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

zackangelo
Copy link
Contributor

What? Why?

This PR contains many changes and is likely to be broken down into several more, but posting diff at the request of @bookernath.

  • Introduces webpack to compile paper-handlebars and its dependencies into a single js file for use with the Blackbird experiment.
  • Removes any dynamic require statements so webpack can figure out what to include at compile time.
  • Introduces polyfills where necessary to remove any dependencies on node.js standard library (most notably url).
  • Removes the handlebars-helpers dependency and vendors the necessary helpers in this repo.
  • Vendors the Translator class from paper (for no other reason than its required for Blackbird), but also not clear to me why that class is in paper vs paper-handlebars.

How was it tested?

n/a


cc @bigcommerce/storefront-team

@zackangelo zackangelo added the WIP Work in progress label Sep 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WIP Work in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant