Merge pull request #152 from bookernath/assignVar-floats

Support floats for assignVar/getVar
bigcommerce · Nov 23, 2021 · d2a0b59 · d2a0b59
2 parents 9490a10 + 4982311
commit d2a0b59
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/helpers/assignVar.js b/helpers/assignVar.js
@@ -11,9 +11,9 @@ const factory = globals => {
             throw new Error("assignVar helper key must be a string");
         }
 
-        // Validate that value is a string or integer
-        if (!utils.isString(value) && !Number.isInteger(value)) {
-            throw new Error("assignVar helper value must be a string or a number (integer)");
+        // Validate that value is a string or Number (int/float)
+        if (!utils.isString(value) && !Number.isFinite(value)) {
+            throw new Error("assignVar helper value must be a string or a number (integer/float)");
         }
 
         // Validate that string is not longer than the max length

diff --git a/spec/helpers/assignVar-getVar.js b/spec/helpers/assignVar-getVar.js
@@ -12,6 +12,7 @@ describe('assignVar and getVar helpers', function() {
         value1: "Big",
         value2: "Commerce",
         value3: 12,
+        value4: -12.34,
         value1300char: "rOiWsgkWKLRm0fve752Upp7qe3QBNBlKaSgMJaG6zbB8TChtbxLfnEbidd6GiJdjm5Q18LDwy24zQxjOpGKqVzbg3cyEh5vwSZvdwl34EMXM8Iqa3QTP2aEXCBhpnoTBBv4USIPU3dmyNRL7Gmx63TyBkVCqrjXZ033KhrDXrGmE9eVGpzNktFxpAiylJHFnQmehKFnsPn5fbicfDChGhTbu3hk4ti9tvmawWziljUmqdGQ8ddovJ2ivz0fSfoC5UoBTOMU4xNJfupFunE1ayncImLJUnDCW1hWC99Qb2AVAMNCzH84V3Pch0cERhxYed87Aw1rH4tMOLBnnOWF6KYDd5hGQLWaSMiv2kS5PHiAfcndquARxnSrAxGY01ly3bSLivoW98AD7poZXb61Skuiw5wSd6rAfr2WXRTlaQWsyJ3r5qqtmg9k5LwH9p76FMKYDOFtf0tqE8nK0ZoSBesASojH3aNLEV9Ad8zXBIv5euClEwDs54aWtYgnAZt1fBz9pDmcwMi32YrHcYDHM2HGDkdfjaGpEsPzvlipBRveXQwmwgxzqNlXoQT98vPSFXKm8WC2dQkcCt8XbMEr5gk37UJNoqhcaAp7vKCentu1iO8y80aN2ggzJ14tHTk5zYpvtk2gplkh6yWri9z99FpHpWoXIHH37EEGaw9KmRju5Gb7GK4HsDhQmkxUajdpcWZGneNQEbQ0kHd3iPaTzioJJ1tLoi4qRoTvttahwIcuxFtOXi6mg6dE60RtlZUPDn8MLsA7o7Ofu6uuzktP8ZyafhmC1YVAO5GPxSi9DAbtAC8EkWFNkD6ZGJdPWCbSGNVjfMwZ5Jn4Y9MpV3hF4wuTj2HLdSmhq0SO9npznJpXX38N6mgMoW9OOSKa2meGT7IzqAH4hzjagHJoKjVz0N06TO5jclv72nyHXv9tfQHyrT5HAHDCWvmqvDKmqyJlmZ78bZLa8CyE1CChqjtI6lhsf2grHw7sHE0wmA3K3TbQuAg1DHxhHZtUzoDHj8JBrW3iSACljFu8KBGnBVEdVV9amvLaZSj466sougBQUcpjfkPKeig7iqJmzqBhA2WXZ03qXoIioCQFxbUuZJ7H53LtK8AbB9Nou8E0eChhEnTE69K3R9g15I8zD8xvFQvat8h62Ac0UBj4SqOvpYwtK0yXY3a87kK341KA7pFH99k0SRtUxAUHSYwnhvSAYHe2oZyDUxoQbF3ElbF68cMWbFB39x40lnKKxV0V6T97JI2lDivSH4r6sJV416P5xh7a21q20gwEmAfEBKSQ20i5f",
     };
 
@@ -35,6 +36,10 @@ describe('assignVar and getVar helpers', function() {
                 input: "{{assignVar 'data1' value1}}{{assignVar 'data2' 12}}{{getVar 'data1'}} {{getVar 'data2'}}",
                 output: 'Big 12',
             },
+            {
+                input: "{{assignVar 'data1' value1}}{{assignVar 'data2' value4}}{{getVar 'data1'}} {{getVar 'data2'}}",
+                output: 'Big -12.34',
+            },
             {
                 input: "{{assignVar 'data1' value1}}{{assignVar 'data2' value2}}{{getVar 'data1'}}{{getVar 'data2'}}",
                 output: 'BigCommerce',